1604115 - Strings should be shown with quotes so the type is recognizable

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Jens]

Attachment: String shows like number

I have a project that enforces type checking (TypeScript, Flow). That is, when data comes from JSON a certain type like number or string is expected for the items in the json.

STR:

1. Have a JSON with a number encoded as string type (this happens more often then you'd think), e.g.

{
  "numberAsNumberType": 1,
  "numberAsStringType": "1"
}

2. Download via https://api.myjson.com/bins/l22e0
3. Look at the Netmonitor, screenshot.

ER:
The string should be surrounded by quotes. The JSON Viewer does it right.

AR:
The string shows like a number what really puzzled me in my project. Of course the above is just a minimal example.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

@Nicolas, looks like we need to update/fix a rep?

Honza

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

This probably comes from: https://searchfox.org/mozilla-central/rev/6bceafe72cad5d5752667b4b6bd595d3a4047ca3/devtools/client/netmonitor/src/components/PropertiesView.js#300

Removing it would add the quotes to all strings

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks!

Honza

Comment 4

[Andres Ortega :cabezota]

Can I do it? :)

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Andres Ortega :cabezota from comment #4)

Can I do it? :)

Hello Andres!

I assigned the bug to you, thanks for offering help!
If you haven't yet, you should go through http://docs.firefox-dev.tools/getting-started/ to setup the work environment. Don't hesitate to ask any question

Comment 6

[Pranav pandey]

(In reply to Andres Ortega :cabezota from comment #4)

Can I do it? :)

Hi Andres if you are not working on it can I give it a try :)

Comment 7

[Andres Ortega :cabezota]

Sure, Pranav. You can do it. I haven't had the time

Comment 8

[Pranav pandey]

Attachment: Bug 1604115 - added useQuoes prop to propertiesView and fixed bug in network response json viewer. r=honza

Comment 9

[Pranav pandey]

Attachment: Bug 1604115 - added useQuoes prop to propertiesView and fixed bug in network response json viewer. r=honza

Comment 10

[Pranav pandey]

hi I have submitted a patch for this bug https://phabricator.services.mozilla.com/D60104

Comment 11

[Pranav pandey]

Attachment: Bug 1604115 - added useQuotes prop to propertiesView and fixed bug in network response json viewer.

Comment 12

[Pranav pandey]

Hi ,
Sorry I have to submit a new patch I tried soo hard but couldn't find a way to add new commits to patch then I destroyed my branch by trying different things then, I also do not how to attach to a branch in phabricator.

Pranav

Comment 13

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Pranav pandey from comment #12)

Sorry I have to submit a new patch I tried soo hard but couldn't find a way to add new commits to patch then I destroyed my branch by trying different things then, I also do not how to attach to a branch in phabricator.

No problem.

Here is, what I usually do to update an existing patch/revision on phabricator

arc diff .^ --update DXXXX

DXXXX => revision number

Honza

Comment 14

[Pranav pandey]

the arc thing was not working for me I also asked it on slack then people said why are you using it .. I have switched to git now and using phlay it is working fine for me

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb244ef46051
added useQuotes prop to propertiesView and fixed bug in network response json viewer. r=Honza

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fb244ef46051