1604188 - Replace unreachable String functions calling MOZ_ASSERT_UNREACHABLE/MOZ_CRASH with if-constexpr

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[André Bargull [:anba]]

For example we can avoid writing this Final_Sigma function:

static Latin1Char Final_Sigma(const Latin1Char* chars, size_t length,
                              size_t index) {
  MOZ_ASSERT_UNREACHABLE("U+03A3 is not a Latin-1 character");
  return 0;
}

when the call sites use if-constexpr to only call Final_Sigma for char16_t.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1604188: Replace unreachable string functions with if-constexpr code. r=jandem!

Instead of using MOZ_CRASH/MOZ_ASSERT_UNREACHABLE for unreachable functions, we can
now use if-constexpr to avoid generating the unreachable calls in the first place.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dfdd760665d
Replace unreachable string functions with if-constexpr code. r=jandem,jwalden

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1dfdd760665d