[wpt-sync] Sync PR 20788 - Improve fidelity of <svg:image> with fractional width and pAR xMinYMin
Categories
(Core :: SVG, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 20788 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/20788
Details from upstream follow.
Fredrik Söderquist <fs@opera.com> wrote:
Improve fidelity of <svg:image> with fractional width and pAR xMinYMin
When painting an image (for \<svg:image>) we would use the rounded size
of the image - even if the image itself had a fractional size (which an
SVG image trivially can have, and painting into a fractional image
"viewport" can yield). This in turn can lead to unnecessary adjustments
when compensation for the aspect ratio and similar.Add Image::SizeAsFloat() to allow Image subclasses to return an
unrounded size and thus preserve the fidelity with which it was
specified. Then pass the unrounded |image_viewport_size| to
LayoutImageResource::GetImage(...) in SVGImagePainter to allow keeping
as much precision as possible for the image dimensions.This reduces (eliminates) the vertical component of the jitter in the
referenced bug.Bug: 753521
Change-Id: I854a56418a3dd242fd0aed759b1961b6e6fbe591
Reviewed-on: https://chromium-review.googlesource.com/1969575
WPT-Export-Revision: 2b9f1282911a316de5664e65e79803427e2f3b91
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a8212b08dd3d599744713479c7f66a055be6807
|
|
Assignee | |
Comment 2•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
FAIL: 1
Chrome
FAIL: 1
Safari
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/svg/embedded/image-fractional-width-vertical-fidelity.svg: FAIL (Chrome: FAIL, Safari: FAIL)
|
|
Assignee | |
Comment 3•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
FAIL: 1
Chrome
FAIL: 1
Safari
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/svg/embedded/image-fractional-width-vertical-fidelity.svg: FAIL (Chrome: FAIL, Safari: FAIL)
|
|
Assignee | |
Comment 4•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
FAIL: 1
Chrome
FAIL: 1
Safari
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/svg/embedded/image-fractional-width-vertical-fidelity.svg: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5aa4fe1c9a6a [wpt PR 20788] - Improve fidelity of <svg:image> with fractional width and pAR xMinYMin, a=testonly https://hg.mozilla.org/integration/autoland/rev/d5e18c3178f2 [wpt PR 20788] - Update wpt metadata, a=testonly
|
|
Assignee | |
Comment 6•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
FAIL: 1
Chrome
FAIL: 1
Safari
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/svg/embedded/image-fractional-width-vertical-fidelity.svg: FAIL (Chrome: FAIL, Safari: FAIL)
|
|
Assignee | |
Comment 7•4 years ago
|
||
Test result changes from PR not available.
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5aa4fe1c9a6a
https://hg.mozilla.org/mozilla-central/rev/d5e18c3178f2
Description
•