1604222 - Add a way to know if an addon is disabled by user or because not supported

Status: RESOLVED FIXED

(GeckoView :: Extensions, enhancement, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

We need to know why the addon was disabled (user disabled vs the addon is incompatible with the app) and for the app a way to set an addon as disabled because it's not compatible with the app.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1604222 - Use destructuring params in updateAddonDisabledState.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1604222 - Add embedderDisabled field to addon.

This allows embedding applications to disable addons independently of the user
disabled field.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1604222 - Implement disable(APP_DISABLED) for WebExtension.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=41bf7bb7739f410709e5c466dfdf6d9336a376ca

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15bf31fa86b9
Use destructuring params in updateAddonDisabledState. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/34eace2047b4
Add embedderDisabled field to addon. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/a135f610a311
Implement disable(APP_DISABLED) for WebExtension. r=snorp

Comment 6

[Razvan Maries]

Backed out for perma fails gv-junit perma fails.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=284755660&resultStatus=testfailed%2Cbusted%2Cexception&revision=a135f610a311b8229bcdccd6b3a441603073b01a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284755660&repo=autoland&lineNumber=11308

Backout: https://hg.mozilla.org/integration/autoland/rev/d1406439c4614f7e84fab2cc2e2630018dd4b942

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f05c8bbfa9a7
Use destructuring params in updateAddonDisabledState. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/8efb33009288
Add embedderDisabled field to addon. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/caa6177248f7
Implement disable(APP_DISABLED) for WebExtension. r=snorp

Comment 8

[[ex-Mozilla] Agi Sferro | :agi]

Thanks! Classic last minute change that breaks the test.

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f05c8bbfa9a7
https://hg.mozilla.org/mozilla-central/rev/8efb33009288
https://hg.mozilla.org/mozilla-central/rev/caa6177248f7