1604244 - Assertion failure: !nsSVGUtils::OuterSVGIsCallingReflowSVG(this) (do not call ScheduleReflowSVGNonDisplayText when the outer SVG frame is under ReflowSVG), at /builds/worker/workspace/build/src/layout/svg/SVGTextFrame.cpp:2857

Status: RESOLVED WORKSFORME

(Core :: SVG, defect, P3)

Description

[Bob Clary [:bc] (inactive)]

1. https://www.mancrates.com/store/personalization/255/preference_item/44185/design
2. Assertion failure: !nsSVGUtils::OuterSVGIsCallingReflowSVG(this) (do not call ScheduleReflowSVGNonDisplayText when the outer SVG frame is under ReflowSVG), at /builds/worker/workspace/build/src/layout/svg/SVGTextFrame.cpp:2857

Nightly Linux (Fedora 30) in Automation. Reproduced locally on Fedora 31 with Nightly and Beta 72.0b5.

Assertion failure: !nsSVGUtils::OuterSVGIsCallingReflowSVG(this) (do not call ScheduleReflowSVGNonDisplayText when the outer SVG frame is under ReflowSVG), at /builds/worker/workspace/build/src/layout/svg/SVGTextFrame.cpp:2857
#01: mozilla::SVGRenderingObserverSet::InvalidateAll() [layout/svg/SVGObserverUtils.cpp:1023]
#02: nsIFrame::FinishAndStoreOverflow(nsOverflowAreas&, nsSize, nsSize*, nsStyleDisplay const*) [layout/generic/nsFrame.cpp:0]
#03: mozilla::SVGGeometryFrame::ReflowSVG() [layout/svg/SVGGeometryFrame.cpp:392]
#04: nsSVGDisplayContainerFrame::ReflowSVG() [layout/svg/nsSVGContainerFrame.cpp:324]
#05: nsSVGViewportFrame::ReflowSVG() [layout/svg/nsSVGViewportFrame.cpp:72]
#06: nsSVGDisplayContainerFrame::ReflowSVG() [layout/svg/nsSVGContainerFrame.cpp:324]
#07: nsSVGDisplayContainerFrame::ReflowSVG() [layout/svg/nsSVGContainerFrame.cpp:324]
#08: nsSVGOuterSVGFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) [layout/svg/nsSVGOuterSVGFrame.cpp:460]
#09: mozilla::PresShell::DoReflow(nsIFrame*, bool, mozilla::OverflowChangedTracker*) [layout/base/PresShell.cpp:9186]
#10: mozilla::PresShell::ProcessReflowCommands(bool) [layout/base/PresShell.cpp:9352]
#11: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [layout/base/PresShell.cpp:4113]
#12: nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/PresShell.h:0]
#13: mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&) [layout/base/nsRefreshDriver.cpp:345]
#14: mozilla::RefreshDriverTimer::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:370]
#15: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) [layout/base/nsRefreshDriver.cpp:742]
#16: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyVsync(mozilla::VsyncEvent const&) [layout/base/nsRefreshDriver.cpp:636]
#17: mozilla::layout::VsyncChild::RecvNotify(mozilla::VsyncEvent const&) [layout/ipc/VsyncChild.cpp:68]
#18: mozilla::layout::PVsyncChild::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources:40b57a5f11db1f2975fc13c74f20fea3c72418dd5cc7be16b1724f135b6995163d22588c816f1fb7f6cdadad80e8ed2fcea1ccf234f0788643e6a5e4e1859c1e/ipc/ipdl/PVsyncChild.cpp::0]
#19: mozilla::ipc::PBackgroundChild::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources:5579cb101527982d72096be9b6fcb46f6d93a5d14564b8f11e1f6a6e8ccd6278d0b51192bc07b23625f16d1978dd8222d850a46e5779288881548c3e9f02aad4/ipc/ipdl/PBackgroundChild.cpp::5876]
#20: mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) [ipc/glue/MessageChannel.cpp:2210]
#21: mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) [ipc/glue/MessageChannel.cpp:2134]
#22: mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) [ipc/glue/MessageChannel.cpp:0]
#23: mozilla::ipc::MessageChannel::MessageTask::Run() [ipc/glue/MessageChannel.cpp:2006]
#24: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1241]
#25: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:486]
#26: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:87]
#27: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
#28: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:139]
#29: XRE_RunAppShell() [toolkit/xre/nsEmbedFunctions.cpp:946]
#30: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:237]
#31: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
#32: XRE_InitChildProcess(int, char**, XREChildData const*) [toolkit/xre/nsEmbedFunctions.cpp:781]
#33: content_process_main(mozilla::Bootstrap*, int, char**) [ipc/contentproc/plugin-container.cpp:57]
#34: main [browser/app/nsBrowserApp.cpp:303]
#35: libc.so.6 + 0x23f43
#36: _start

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:TYLin, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

The url in comment 0 redirects to https://www.mancrates.com/store/products/personalized-barware-crate, and I cannot reproduce with it.

Bob, can you still reproduce it? A static page is very helpful for further investigation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:TYLin, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Bob Clary [:bc] (inactive)]

I can't reproduce the particular assertion using Nighlty on Fedora. Instead I am hitting Assertion failure: NS_IsMainThread() (Should only queue idle runnables on main thread). I'll mark it wfm for now and will reopen if I can reproduce.

Comment 5

[Bob Clary [:bc] (inactive)]

TYLin: https://www.mancrates.com/store/personalization/255/preference_item/44185/design?preference_id=28697 reproduces this for me in Windows and Linux this morning. If you can take a look quickly, you may be able to reproduce. Note after the first attempt, you may start getting Assertion failure: NS_IsMainThread() . You'll need to clear you cache to reproduce again.

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Reduced test case for www.mancrates.com.html

Thanks! I save a page that can reproduce the crash on my local debug build.

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Cameron, this looks similar to bug 897887 that you fixed before. Could you take a look?

Comment 8

[Cameron McCormack (:heycam)]

Sorry, forgot to take a look at this.

Comment 9

[Robert Longson [:longsonr]]

Doesn't seem to assert any more.