1604318 - get Blink's layout microbenchmarks running in Gecko

Status: NEW

(Core :: Layout, task)

Description

[Cameron McCormack (:heycam)]

It would be great to get Blink's benchmarks they developed during their LayoutNG rewrite running in Gecko.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I poked a bit at this. They're regular HTML / JS files so they just run in other browsers.

See http://crisal.io/tmp/blink-perf-tests/layout for some of them.

So AFAICT this is just a matter of getting them landed and hooked properly into Talos / Raptor if we wanted... Joel, do you know who's the right person to do this / guide me doing this?

In particular, this seems to be just using WebKit's perf runner, with some minor tweaks.

• Do we have similar hooks for other WebKit / Blink perf tests?
• Does this seem too hard? AFAIK, apart from all the raptor plumbing and such, we'd need to hook into finish in their runner.js file. How would raptor read the measurements? These tests seem to mostly measure runs/s (more is better).

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Diff between Chromium's and WebKit's perf tests.

This is also interesting.

It seems like Blink has added missing descriptions for some tests, unprefixed some bits, and tweaked some of them.

WebKit has added more tests, looks like.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9116495 [details] [diff] [review]
Diff between Chromium's and WebKit's perf tests.

Trying to convince Bugzilla to show me a nicer UI.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

(According to Jesup, Dave may be a better person to answer the questions in comment 2?)

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Thanks for looking into this Emilio. Your added details make this much more actionable.

I believe speedometer and stylebench will have reasonable prior art to work from:
https://searchfox.org/mozilla-central/search?q=perftestrunner&path=

and yes, :davehunt will be the right person to look into this (his team manages talos/raptor for the last year)

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I suggest looking over the relatively recent addition of Jetstream 2 for an example of adding a benchmark to Raptor. This was added via bug 1542046. If you have further questions you can reach out to :rwood or :sparky.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Ok I'll give that a shot.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Waiting on bug 1604860 for now.