1604335 - Temporarily enable PHC on beta

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Description

[Nicholas Nethercote [inactive]]

We want to enable PHC on beta builds for a short period, before disabling it again (bug 1599337).

Comment 1

[Nicholas Nethercote [inactive]]

(Note: the previous attempt at this, bug 1594595, failed because the moz.configure change was incorrect.)

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: [DRAFT] Bug 1604335 - Temporarily enable PHC on beta. r=glandium

XX: but it's not actually working, AFAICT. Consider this try push, which I did
from a mozilla-beta repository:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e61340a56df4c1c459c8b107808f507e39830ef

I inserted a deliberate PHC gtest error, but the Gtest job succeeded, and the
log shows that PHC tests didn't run. So I don't know if I've done something
wrong, or if the try job is somehow different to the shipped beta builds, or
what.

Comment 3

[Mike Hommey [:glandium]]

Your try push is only doing debug builds, which don't build with the beta mozconfigs, but with the debug ones. You want the shippable builds instead.

BTW, you shouldn't need --enable-replace-malloc in the mozconfigs.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1604335 - Enable PHC on early beta.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/216df035bdf5
Enable PHC on early beta. r=erahm

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/216df035bdf5