Closed Bug 1604335 Opened 2 years ago Closed 2 years ago

Temporarily enable PHC on beta

Categories

(Core :: Memory Allocator, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: n.nethercote, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

We want to enable PHC on beta builds for a short period, before disabling it again (bug 1599337).

(Note: the previous attempt at this, bug 1594595, failed because the moz.configure change was incorrect.)

XX: but it's not actually working, AFAICT. Consider this try push, which I did
from a mozilla-beta repository:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e61340a56df4c1c459c8b107808f507e39830ef

I inserted a deliberate PHC gtest error, but the Gtest job succeeded, and the
log shows that PHC tests didn't run. So I don't know if I've done something
wrong, or if the try job is somehow different to the shipped beta builds, or
what.

Your try push is only doing debug builds, which don't build with the beta mozconfigs, but with the debug ones. You want the shippable builds instead.

BTW, you shouldn't need --enable-replace-malloc in the mozconfigs.

Assignee: n.nethercote → mh+mozilla
Depends on: 1599337, 1597834
Attachment #9116263 - Attachment is obsolete: true
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/216df035bdf5
Enable PHC on early beta. r=erahm
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.