1604359 - Intermittent browser_manager.js | Should be displaying 4 accounts - 4 == 0 - JS frame :: chrome://mochitests/content/browser/comm/mail/test/browser/cloudfile/browser_manager.js :: test_load_accounts_and_properly_order :: line 97

Status: RESOLVED FIXED

(Thunderbird :: FileLink, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: geoff [at] darktrojan.net
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=281461814&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/at2qj9G9TVmkusy31HFFUA/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Intermittent Failures Robot]

10 failures in 4582 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 10

Platform breakdown:

• macosx1014-64: 2
• windows7-32: 2
• linux32: 3
• linux64: 2
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1604359&startday=2019-12-16&endday=2019-12-22&tree=all

Comment 2

[Intermittent Failures Robot]

5 failures in 1365 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 5

Platform breakdown:

• windows7-32: 2
• linux64: 2
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1604359&startday=2019-12-23&endday=2019-12-29&tree=all

Comment 3

[Intermittent Failures Robot]

7 failures in 1862 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 7

Platform breakdown:

• windows7-32: 2
• windows10-64: 2
• linux32: 1
• macosx1014-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1604359&startday=2019-12-30&endday=2020-01-05&tree=all

Comment 4

[Intermittent Failures Robot]

14 failures in 4472 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 14

Platform breakdown:

• linux32: 3
• macosx1014-64: 1
• windows7-32: 3
• linux64: 4
• windows10-64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1604359&startday=2020-01-06&endday=2020-01-12&tree=all

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1604359-cloudfile-manager-test-1.diff

We should be able to knock this off by rewriting the test in a modern way.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9121457 [details] [diff] [review]
1604359-cloudfile-manager-test-1.diff

Review of attachment 9121457 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, with some nits. r=mkmelin

::: mail/components/preferences/test/browser/browser_cloudfile.js
@@ +35,2 @@
>  
> +let mockPromptService = {

Please add @implements {nsIPromptService}

@@ +40,5 @@
> +    return true;
> +  },
> +  QueryInterface: ChromeUtils.generateQI([Ci.nsIPromptService]),
> +};
> +let mockExternalProtocolService = {

Can we add some @implements {nsIExternalProtocolService}  to make it more clear and less XPCOMy

@@ +60,4 @@
>  
> +let { MockRegistrar } = ChromeUtils.import(
> +  "resource://testing-common/MockRegistrar.jsm"
> +);

would be nicer to have the imports on top of the file

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/03dcd29772aa
Rewrite CloudFile preferences test without Mozmill modules; r=mkmelin DONTBUILD

Comment 8

[Jorg K (CEST = GMT+2)]

Where did test_external_link() go?

Comment 9

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/comm-central/rev/03dcd29772aa#l1.157

Comment 10

[Intermittent Failures Robot]

5 failures in 3773 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 5

Platform breakdown:

• windows10-64: 3
• linux32: 1
• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1604359&startday=2020-01-13&endday=2020-01-19&tree=all