Closed Bug 1604366 Opened 7 months ago Closed 7 months ago

Split login manager auth prompt code from DOM/form prompting code

Categories

(Toolkit :: Password Manager, task, P1)

task

Tracking

()

VERIFIED FIXED
mozilla73
Tracking Status
firefox73 --- verified

People

(Reporter: MattN, Assigned: MattN)

References

Details

(Whiteboard: [passwords:tech-debt])

Attachments

(1 file)

In order to make the implementation of non-HTTP-auth login prompts cleaner for GeckoView (bug 1599873) and to reduce the size/complexity of LoginManagerPrompter.jsm, we can split the file into two:

  1. Handle HTTP auth prompts
  2. Handle non-HTTP-auth (e.g. <form>) prompts (doorhangers)

The latter is much simpler and can simply use static methods and won't need the unusual init function and setters. The logic for determining which browser/window to use also won't need to duplicated between desktop and mobile.

Attachment #9116279 - Attachment description: Bug 1604366 - Split login manager auth prompt code from DOM/form prompting code. → Bug 1604366 - Split login manager auth prompt code from DOM/form prompting code. r=sfoster
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/8f7c8adba974
Split login manager auth prompt code from DOM/form prompting code. r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/992dc71f9c70
Port bug 1604366 - Split login manager auth prompt code from DOM/form prompting code. rs=bustage-fix DONTBUILD

It would be great if QA could verify that FTP, HTTP auth and proxy authentication dialog behaviours didn't regress.

Flags: qe-verify+

Compared behavior for HTTP, Proxy authentication dialogs and FTP authentication on Firefox 72 Beta and the latest Nightly 73 - Windows 10 x64 and Ubuntu 18.04

  • For HTTP auth there are no differences between the two FX versions, this includes: credentials saving/update via doorhanger, autofill, about:logins correct storage (Used site: https://www.httpwatch.com/httpgallery/authentication/)

  • For FTP proxy authentication dialog there are no differences: credentials saved/edited via the checkbox, autofill, about:logins correct storage (Used company proxy setup)

Note that the above dialogs do not have field autocomplete dropdowns available, thus the first saved credentials are always auto-filled

FTP authentication has issues in the latest Nightly, there is only a blank page displayed upon accessing a FTP page that should display an authentication dialog, this is mainly https://bugzilla.mozilla.org/show_bug.cgi?id=1144631#c5 which seems like it regressed.

Aside from the FTP authentication problem (which I will redirect to it's bug) the other two dialogs did not reveal any issues.
Please let me know if there are further needed verifications here.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.