Closed Bug 1604371 Opened 4 months ago Closed 2 months ago

Intermittent comm/mail/components/preferences/test/browser/browser_cloudfile.js | undefined assertion name - Got 0, expected 1 ** Artifact builds only **

Categories

(Thunderbird :: FileLink, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 74.0

People

(Reporter: intermittent-bug-filer, Assigned: darktrojan)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: geoff [at] darktrojan.net
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=281458543&repo=try-comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/HBBzhkrISaS3_1aFa4gPgw/runs/0/artifacts/public/logs/live_backing.log


This happens because the built_in_addons.json file doesn't include WeTransfer in artifact builds. This bug exists so that people see it's a known failure in Try runs.

I got annoyed enough with this bug to code a solution.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9123604 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9123604 [details] [diff] [review]
1604371-fake-wetransfer-1.diff

Review of attachment 9123604 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/preferences/test/browser/browser_cloudfile.js
@@ +16,5 @@
> +  let weTransfer = await AddonManager.getAddonByID(
> +    "wetransfer@extensions.thunderbird.net"
> +  );
> +  if (!weTransfer) {
> +    // WeTransfer isn't registered in artifact builds.

Seems fine as a stop gap, but do we know why it's not registered in artifact builds?
Attachment #9123604 - Flags: review?(mkmelin+mozilla) → review+

Yes. Our version of built_in_addons.json is not used. The toolkit one is.

Ok, can you add a comment about that in the code.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/a2cc7c9b4a06
Fix browser_cloudfile.js in artifact builds by registering a fake provider. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 74.0
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/676178d1f672
follow-up - add a missing comma. rs=linting DONTBUILD
You need to log in before you can comment on or make changes to this bug.