1604399 - Dead assignment in Sgpd::Parse

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Alex Henrie]

Sgpd::Parse currently has some code that looks like this:

const uint8_t version = flags >> 24;
flags = flags & 0xffffff;

Zeroing out the first 8 bits of the flags variable is pointless for two reasons: First, flags is never used except to get the version. Second, if we were to start using flags for something else in the future, the bitwise AND to check for any particular flag would zero out all irrelevant bits including the first 8.

Comment 1

[Alex Henrie]

Attachment: Bug 1604399 - Remove dead assignment from Sgpd::Parse.

Comment 2

[Jean-Yves Avenard [:jya]]

nit: it doesn't zero out the first 8 bits, but the last 8.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7d97d4f05a0
Remove dead assignment from Sgpd::Parse. r=jya

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a7d97d4f05a0