accountconfig: "this.resizeDialog is not a function" error is displayed when the initial mail server config is finished (in relation to the insecure warning)
Categories
(Thunderbird :: Account Manager, defect)
Tracking
(thunderbird68 unaffected, thunderbird71 affected, thunderbird72 affected, thunderbird73 affected)
| Tracking | Status | |
|---|---|---|
| thunderbird68 | --- | unaffected |
| thunderbird71 | --- | affected |
| thunderbird72 | --- | affected |
| thunderbird73 | --- | affected |
People
(Reporter: ishikawa, Assigned: mkmelin)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
|
580.80 KB,
image/png
|
Details | |
|
8.45 KB,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
The screen when the error popped up.
C-C TB.
I ran the locally compiled C-C TB [full debug version if that matters], and
did not quite set up the mail server configuration completely: I typed ishikawa@localhost as my e-mail address and thus automatic configuration could not succeed. But I simply proceeded to leave it there, when the said error appears on the screen. (Screen image attached.)
It was also visible in the error/dump log in the console where thunderbird was invoked.
2019-12-17 16:03:46 mail.setup ERROR Error creating account. ex=TypeError: this.resizeDialog is not a function, stack=open@chrome://messenger/content/accountcreation/emailWizard.js:2263:10
onCreate@chrome://messenger/content/accountcreation/emailWizard.js:1935:30
oncommand@chrome://messenger/content/accountcreation/emailWizard.xul:1:20
|
Reporter | |
Updated•4 years ago
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Regression from https://hg.mozilla.org/comm-central/rev/7c267fcfa482 (bug 1590503). We have two different "dialog" objects here so "this" won't work (the other dialog doesn't have that).
|
|
Assignee | |
Comment 2•4 years ago
|
||
The resizing doesn't really belong inside the object anyway...
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 3•4 years ago
|
||
Comment on attachment 9116669 [details] [diff] [review] bug1604409_resizedialog.patch Review of attachment 9116669 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks for taking care of this and apologies for the regression. r=aleca
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9b1de1fb2008
account config: for insecure warning, call a proper resize function. r=aleca
As per bug 1601811, shouldn't the patch use window.resizeBy() instead of changing window.inner*?
|
|
Assignee | |
Comment 6•4 years ago
|
||
Yes, probably. The patch in bug 1601811 couldn't be properly tested due to this bug. Just separating concerns.
Description
•