Closed Bug 1604429 Opened 4 years ago Closed 4 years ago

Component loader doesn't handle uninitialized lexicals correctly

Categories

(Core :: XPConnect, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

In bug 1603373 I tightened up MagicValue assertions in the JS engine.

After this landed, Thunderbird devs got assertion failures, bug 1604190. I think what's happening is that ResolveModuleObjectPropertyById can return a lexcical environment, and its properties can be the MagicValue(JS_UNINITIALIZED_LEXICAL) for uninitialized let/const.

I'll try to write a test for this.

Bug 1603373 tightened up JS engine assertions around this, but that broke
Thunderbird tests.

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1a6d6a378bd
Check for the uninitialized-lexical MagicValue in the component loader. r=kmag
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: