Closed Bug 1604462 Opened 6 years ago Closed 6 years ago

Perma Early Beta win bustage build/src/toolkit/components/telemetry/core/Telemetry.cpp when Gecko 73 merges to beta on 2020-01-06

Tracking

()

Status:

VERIFIED FIXED

Milestone:

mozilla73

Project Flags:

Root Cause

Coding: Semantic Error

Tracking Flags:

Tracking

Status

firefox-esr68

---

unaffected

firefox71

---

unaffected

firefox72

---

unaffected

firefox73

blocking

verified

People

(Reporter: apavel, Assigned: toshi)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1604462 - Include other/UntrustedModules.h in beta build. r=aklotz 6 years ago Toshihito Kikuchi [:toshi] 47 bytes, text/x-phabricator-request		Details \| Review

Andreea Pavel [:apavel]

Reporter

Description

•

6 years ago

[Tracking Requested - why for this release]:

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=e13d2079719a737bb4da4aa34fa63ee196b56129&selectedJob=281529341

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281529341&repo=try&lineNumber=34524

[task 2019-12-17T12:17:04.893Z] 12:17:04 [task 2019-12-17T12:17:04.893Z] 12:17:04 [task 2019-12-17T12:17:04.932Z] 12:17:04 [task 2019-12-17T12:17:04.932Z] 12:17:04 [task 2019-12-17T12:17:04.932Z] 12:17:04 [task 2019-12-17T12:17:06.351Z] 12:17:06 [task 2019-12-17T12:17:06.353Z] 12:17:06 [task 2019-12-17T12:17:06.353Z] 12:17:06 [task 2019-12-17T12:17:06.363Z] 12:17:06 [task 2019-12-17T12:17:06.363Z] 12:17:06 [task 2019-12-17T12:17:06.363Z] 12:17:06 [task 2019-12-17T12:17:06.364Z] 12:17:06 [task 2019-12-17T12:17:06.364Z] 12:17:06 [task 2019-12-17T12:17:06.364Z] 12:17:06 [task 2019-12-17T12:17:06.364Z] 12:17:06 [task 2019-12-17T12:17:06.364Z] 12:17:06 [task 2019-12-17T12:17:06.364Z] 12:17:06 [task 2019-12-17T12:17:06.365Z] 12:17:06 [task 2019-12-17T12:17:06.365Z] 12:17:06 [task 2019-12-17T12:17:06.365Z] 12:17:06 [task 2019-12-17T12:17:06.365Z] 12:17:06 [task 2019-12-17T12:17:06.365Z] 12:17:06 [task 2019-12-17T12:17:06.384Z] 12:17:06 [task 2019-12-17T12:17:06.384Z] 12:17:06 [task 2019-12-17T12:17:06.384Z] 12:17:06 [task 2019-12-17T12:17:06.384Z] 12:17:06 INFO - mkdir -p '.deps/'
INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/toolkit/components/url-classifier'
INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/toolkit/components/url-classifier'
INFO - toolkit/components/url-classifier/HashStore.obj
INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/toolkit/components/url-classifier'
INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/toolkit/components/thumbnails'
INFO - z:/build/fetches/sccache/sccache.exe z:/build/fetches/clang/bin/clang-cl.exe -Xclang -std=c++17 --target=aarch64-windows-msvc -FoUnified_cpp_thumbnails0.obj -c -flto=thin -fuse-ld=lld -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/toolkit/components/thumbnails -Iz:/build/build/src/obj-firefox/toolkit/components/thumbnails -Iz:/build/build/src/netwerk/base -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -fcrash-diagnostics-dir=z:/build/public/build -TP -nologo -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -O2 -Oy- -Werror -Xclang -MP -Xclang -dependency-file -Xclang .deps/Unified_cpp_thumbnails0.obj.pp -Xclang -MT -Xclang Unified_cpp_thumbnails0.obj Unified_cpp_thumbnails0.cpp
INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/toolkit/components/thumbnails'
INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/toolkit/components/telemetry'
INFO - z:/build/fetches/sccache/sccache.exe z:/build/fetches/clang/bin/clang-cl.exe -Xclang -std=c++17 --target=aarch64-windows-msvc -FoTelemetry.obj -c -flto=thin -fuse-ld=lld -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC '-DMOZ_APP_VERSION="73.0"' -DSTATIC_EXPORTABLE_JS_API -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/toolkit/components/telemetry -Iz:/build/build/src/obj-firefox/toolkit/components/telemetry -Iz:/build/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/build/build/src/ipc/chromium/src -Iz:/build/build/src/ipc/glue -Iz:/build/build/src/xpcom/build -Iz:/build/build/src/xpcom/threads -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -fcrash-diagnostics-dir=z:/build/public/build -TP -nologo -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -O2 -Oy- -Werror -Xclang -MP -Xclang -dependency-file -Xclang .deps/Telemetry.obj.pp -Xclang -MT -Xclang Telemetry.obj z:/build/build/src/toolkit/components/telemetry/core/Telemetry.cpp
INFO - z:/build/build/src/toolkit/components/telemetry/core/Telemetry.cpp(689,10): error: no member named 'GetUntrustedModuleLoadEvents' in namespace 'mozilla::Telemetry'; did you mean simply 'GetUntrustedModuleLoadEvents'?
INFO - return Telemetry::GetUntrustedModuleLoadEvents(cx, aPromise);
INFO - ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
INFO - GetUntrustedModuleLoadEvents
INFO - z:/build/build/src/toolkit/components/telemetry/core/Telemetry.cpp(687,16): note: 'GetUntrustedModuleLoadEvents' declared here
INFO - TelemetryImpl::GetUntrustedModuleLoadEvents(JSContext* cx, Promise** aPromise) {
INFO - ^
INFO - 1 error generated.
INFO - z:/build/build/src/config/rules.mk:736: recipe for target 'Telemetry.obj' failed
INFO - mozmake.EXE[4]: *** [Telemetry.obj] Error 1
INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/toolkit/components/telemetry'
INFO - mozmake.EXE[4]: *** Waiting for unfinished jobs....
INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/toolkit/components/telemetry'
INFO - toolkit/components/telemetry/ProcessedStack.obj
INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/toolkit/components/telemetry'
INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/toolkit/components/url-classifier'

Flags: needinfo?(aklotz)

Andreea Pavel [:apavel]

Reporter

Updated

•

6 years ago

Summary: Perma win bustage build/src/toolkit/components/telemetry/core/Telemetry.cpp when Gecko 73 merges to beta on 06-01-20 → Perma win bustage build/src/toolkit/components/telemetry/core/Telemetry.cpp when Gecko 73 merges to beta on 2020-01-06

Ryan VanderMeulen (PTO, back July 27)

Updated

•

6 years ago

Severity: normal → blocker

status-firefox73: unaffected → affected

tracking-firefox73: ? → blocking

Priority: -- → P1

Ryan VanderMeulen (PTO, back July 27)

Updated

•

6 years ago

Flags: needinfo?(tkikuchi)

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Updated

•

6 years ago

Summary: Perma win bustage build/src/toolkit/components/telemetry/core/Telemetry.cpp when Gecko 73 merges to beta on 2020-01-06 → Perma Early Beta win bustage build/src/toolkit/components/telemetry/core/Telemetry.cpp when Gecko 73 merges to beta on 2020-01-06

Toshihito Kikuchi [:toshi]

Assignee

Comment 1

•

6 years ago

Sorry. I've got the root cause. We need to replace this NIGHTLY_BUILD with EARLY_BETA_OR_EARLIER, too.

Flags: needinfo?(tkikuchi)

Toshihito Kikuchi [:toshi]

Assignee

Comment 2

•

6 years ago

Attached file Bug 1604462 - Include other/UntrustedModules.h in beta build. r=aklotz — Details

Phabricator Automation

Updated

•

6 years ago

Assignee: nobody → tkikuchi

Status: NEW → ASSIGNED

(No longer employed by Mozilla) Aaron Klotz

Updated

•

6 years ago

Flags: needinfo?(aklotz)

Pulsebot

Comment 3

•

6 years ago

Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b7a2a12c69f Include other/UntrustedModules.h in beta build. r=aklotz

Arthur Iakab [arthur_iakab]

Comment 4

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/5b7a2a12c69f

Status: ASSIGNED → RESOLVED

Closed: 6 years ago

status-firefox73: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla73

BugBot [:suhaib / :marco/ :calixte]

Updated

•

6 years ago

Keywords: regression

Cristina Coroiu [:ccoroiu]

Comment 5

•

6 years ago

Verified as fixed with this beta sim:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d5e8ec9c731fb8d8493c8edf087f4b74405dcf5&searchStr=windows%2C2012%2Caarch64%2Copt%2Cbuild-win64-aarch64%2Fopt%2C%28b%29&selectedJob=281717065

Status: RESOLVED → VERIFIED

status-firefox73: fixed → verified

Firefox Bug Husbandry Bot

Comment 6

•

6 years ago

Please specify a root cause for this bug. See :tmaity for more information.

Root Cause: --- → ?

Chris H-C :chutten

Updated

•

6 years ago

Root Cause: ? → Coding: Semantic Error

BMO Automation

Updated

•

6 years ago

Has Regression Range: --- → yes

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Perma Early Beta win bustage build/src/toolkit/components/telemetry/core/Telemetry.cpp when Gecko 73 merges to beta on 2020-01-06

Categories

(Toolkit :: Telemetry, defect, P1)

Tracking

()

People

(Reporter: apavel, Assigned: toshi)

References

(Regression)

Details

(Keywords: regression)

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Updated

Updated

Updated

Updated

Comment 1

Comment 2

Updated

Updated

Comment 3

Comment 4

Updated

Comment 5

Comment 6

Updated

Updated

Attachment

General

Description

File Name

Content Type