Closed Bug 1604484 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 20812 - Use LayoutUnit for SVGImage's "container size"

Categories

(Core :: SVG, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20812 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20812
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Use LayoutUnit for SVGImage's "container size"

Impedance-wise this is slightly better since we generally start out as
float, and thus we won't lose as much precision. This means that viewBox
transform computations and similar will be more accurate.

Make the (recently added) test
wpt/svg/embedded/image-fractional-width-vertical-fidelity.svg slightly more
conservative.

Bug: 812239
Change-Id: I231f596f854ef37ae4e0d2dc3b705e546ee187d4
Reviewed-on: https://chromium-review.googlesource.com/1969672
WPT-Export-Revision: 123fe8fb39fdbf0f26f15b9387c6e1acc7c6c12e

PR 20812 applied with additional changes from upstream: 492ac51367f29fab127859f58ffb4038c9a2fad5
Component: web-platform-tests → SVG
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/svg/embedded/image-fractional-width-vertical-fidelity.svg: FAIL (Chrome: FAIL, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/svg/embedded/image-fractional-width-vertical-fidelity.svg: FAIL (Chrome: FAIL, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/svg/embedded/image-fractional-width-vertical-fidelity.svg: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85ce5b369e8e
[wpt PR 20812] - Use LayoutUnit for SVGImage's "container size", a=testonly

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/svg/embedded/image-fractional-width-vertical-fidelity.svg: FAIL (Chrome: FAIL, Safari: FAIL)

Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.