160450 - WIDGET_DLL & GFXWIN_DLL are incorrect on windows

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Stephen Walker]

Windows is pulling in the defaults for WIDGET_DLL & GFXWIN_DLL from
http://lxr.mozilla.org/seamonkey/source/configure.in#457 &
http://lxr.mozilla.org/seamonkey/source/configure.in#458 which leads to 
-DWIDGET_DLL=\"libwidget_windows.dll\" -DGFXWIN_DLL=\"libgfx_windows.dll\" being
used.

Comment 1

[hacker formerly known as [e-mail]]

Attachment: use LIB_PREFIX in DLL names

Comment 2

[Stephen Walker]

With the patch the dlls would turn out to be defined as widget_windows.dll &
gfx_windows.dll, but that won't work because windows has to be different from
every other platform. On Windows, both dlls are prefixed by 'gk', the gfx dll
uses 'win' instead of 'windows', and the widget dll doesn't even contain the
toolkit name. The dlls end up being named gkgfxwin.dll & gkwidget.dll.

Comment 3

[hacker formerly known as [e-mail]]

Attachment: use win32 specific names

Comment 4

[Stephen Walker]

Won't having $(MOZ_WIDGET_TOOLKIT) & $(MOZ_GFX_TOOLKIT)in those 2 lines end up 
defining the dlls as gkwidgetwindows.dll & gkgfxwinwindows.dll instead of 
gkwidget.dll & gkgfxwin.dll?

Comment 5

[hacker formerly known as [e-mail]]

Attachment: fixing names again

Obviously, I need more that 2.5 hrs of sleep a night. :-P

Comment 6

[Daniel (Leaf) Nunes]

Comment on attachment 94435 [details] [diff] [review]
fixing names again

r=leaf

Comment 7

[hacker formerly known as [e-mail]]

Patch has been checked in.