Closed Bug 1604558 Opened 2 years ago Closed 2 years ago

Simplify and clarify handling of tellDebuggerAboutCompiledScript

Categories

(Core :: JavaScript Engine, task, P1)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mgaudet, Assigned: mgaudet)

References

Details

Attachments

(1 file)

Bug 1604558 - Simplify and clarify handling of tellDebuggerAboutCompiledScript r?tcampbell
47 bytes, text/x-phabricator-request
Details | Review

Right now tellDebuggerAboutCompiledScript is quite confusingly implemented:

It only fires if we are both on-the-main-thread, for non-lazy scripts with null parents (which means top level!)

It seems that this mostly is indicating that this API is implemented at the wrong place and ought to be moved to the top level entrances of the compiler.

Assignee: nobody → mgaudet
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3dc47180c833
Simplify and clarify handling of tellDebuggerAboutCompiledScript r=tcampbell

https://hg.mozilla.org/mozilla-central/rev/3dc47180c833

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.