Enable pgo on macOS shippable builds
Categories
(Firefox Build System :: General, task)
Tracking
(relnote-firefox -, firefox73 fixed)
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(2 files)
Once we run them through try a few times and double check with release we should flip on pgo for nightlies and remove the separate macosx pgo jobs.
|
Assignee | |
Comment 1•4 years ago
|
||
Ryan, do you have any input from the release management side of things as to whether we do this now (with about two weeks until the merge to beta), or immediately after the merge?
Also, let me know if there's someone else I need to be asking :-) Thanks!
|
||
Comment 2•4 years ago
|
||
We've got about 3 weeks until 73 merges to Beta (6-Jan), so I think there's time to land this still and revert if things get crazy.
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
|
Assignee | |
Comment 4•4 years ago
|
||
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3246ff1e880 Fix pgo enable variable name in macOS mozconfig. r=firefox-build-system-reviewers,mshal https://hg.mozilla.org/integration/autoland/rev/65cf656ecce9 Enable pgo on macOS shippable builds. r=firefox-build-system-reviewers,mshal
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d3246ff1e880
https://hg.mozilla.org/mozilla-central/rev/65cf656ecce9
|
||
Comment 7•4 years ago
|
||
Nice work!
|
||
Comment 8•4 years ago
|
||
== Change summary for alert #24535 (as of Thu, 19 Dec 2019 11:30:38 GMT) ==
Improvements:
32% perf_reftest_singletons tiny-traversal-singleton.html macosx1014-64-shippable opt e10s stylo 1,166.29 -> 790.59
26% perf_reftest_singletons abspos-reflow-1.html macosx1014-64-shippable opt e10s stylo 82.87 -> 61.54
25% perf_reftest_singletons external-string-pass.html macosx1014-64-shippable opt e10s stylo 1,121.51 -> 839.25
19% perf_reftest_singletons slow-selector-1.html macosx1014-64-shippable opt e10s stylo 0.12 -> 0.10
19% perf_reftest_singletons display-none-1.html macosx1014-64-shippable opt e10s stylo 0.13 -> 0.10
18% perf_reftest_singletons only-children-1.html macosx1014-64-shippable opt e10s stylo 0.12 -> 0.10
17% perf_reftest_singletons slow-selector-2.html macosx1014-64-shippable opt e10s stylo 0.12 -> 0.10
17% perf_reftest_singletons id-getter-2.html macosx1014-64-shippable opt e10s stylo 1,001.26 -> 833.28
16% perf_reftest_singletons parent-basic-singleton.html macosx1014-64-shippable opt e10s stylo 198.65 -> 166.95
15% perf_reftest_singletons bidi-resolution-1.html macosx1014-64-shippable opt e10s stylo 192.40 -> 162.91
13% perf_reftest_singletons scrollbar-styles-1.html macosx1014-64-shippable opt e10s stylo 633.10 -> 551.52
12% perf_reftest_singletons id-getter-1.html macosx1014-64-shippable opt e10s stylo 555.15 -> 486.13
12% perf_reftest_singletons coalesce-2.html macosx1014-64-shippable opt e10s stylo 224.03 -> 197.22
12% perf_reftest_singletons coalesce-1.html macosx1014-64-shippable opt e10s stylo 275.41 -> 242.59
11% perf_reftest_singletons id-getter-3.html macosx1014-64-shippable opt e10s stylo 543.45 -> 481.66
11% perf_reftest_singletons id-getter-6.html macosx1014-64-shippable opt e10s stylo 541.35 -> 480.76
11% perf_reftest_singletons id-getter-4.html macosx1014-64-shippable opt e10s stylo 542.11 -> 481.56
11% perf_reftest_singletons id-getter-5.html macosx1014-64-shippable opt e10s stylo 540.76 -> 480.95
10% perf_reftest_singletons id-getter-7.html macosx1014-64-shippable opt e10s stylo 539.90 -> 483.63
10% a11yr macosx1014-64-shippable opt e10s stylo 203.48 -> 183.15
10% perf_reftest_singletons window-named-property-get.html macosx1014-64-shippable opt e10s stylo 767.13 -> 693.46
8% perf_reftest_singletons bloom-basic.html macosx1014-64-shippable opt e10s stylo 80.24 -> 74.03
7% perf_reftest some-descendants-1.html macosx1014-64-shippable opt e10s stylo 8.47 -> 7.88
6% tp5o macosx1014-64-shippable opt e10s stylo 355.08 -> 333.77
6% perf_reftest_singletons bloom-basic-2.html macosx1014-64-shippable opt e10s stylo 78.28 -> 73.80
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24535
|
||
Comment 9•4 years ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]: PGO will improve Firefox performance.
[Affects Firefox for Android]: No. This change only affects macOS. Firefox already uses PGO on Android, Windows, and Linux.
[Suggested wording]: Enable PGO (Profile-Guided Optimizations) performance improvements on macOS.
[Links (documentation, blog post, etc)]: None
This note can be listed in the release notes' "Changed" section.
|
|
||
Comment 10•4 years ago
|
||
I can't find any previous instance of including PGO in the release notes and in general it feels a bit overly-technical for something user-facing. I guess we could maybe include a more generic "performance improvements on macOS" comment, but I'm not sure that's really worth calling out either. Feel free to NI and state your case if you feel strongly otherwise, though.
Description
•