1604585 - Remove write-only HashTable member.

Status: RESOLVED INVALID

(Core :: MFBT, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1604585 - Remove HashTable::mEntered, as it is write-only. r=froydnj

And while at it, initialize mMutationCount in the declaration, to remove an
ugly ifdef block.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/310c4bf09003
Remove HashTable::mEntered, as it is write-only. r=froydnj

Comment 3

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=310c4bf09003ad2bc467ea170d96de2c9346b341&selectedJob=281594708

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=281594708&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/0828633f96ee6231072bd24fa0e61131c386c0a3

[task 2019-12-17T18:51:21.047Z] /builds/worker/workspace/build/src/js/src/gc/Nursery.h:309:5: required from here
[task 2019-12-17T18:51:21.047Z] /builds/worker/workspace/build/src/obj-spider/dist/include/mozilla/ReentrancyGuard.h:29:23: error: 'const class mozilla::detail::HashTable<void* const, mozilla::HashSet<void*, mozilla::PointerHasher<void*>, js::SystemAllocPolicy>::SetHashPolicy, js::SystemAllocPolicy>' has no member named 'mEntered'; did you mean 'Entry'?
[task 2019-12-17T18:51:21.047Z] : mEntered(aObj.mEntered)
[task 2019-12-17T18:51:21.047Z] ~~~~~^~~~~~~~
[task 2019-12-17T18:51:21.047Z] Entry
[task 2019-12-17T18:51:21.088Z] /builds/worker/workspace/build/src/obj-spider/dist/include/mozilla/ReentrancyGuard.h: In instantiation of 'mozilla::ReentrancyGuard::ReentrancyGuard(T&, mozilla::detail::GuardObjectNotifier&&) [with T = const mozilla::detail::HashTable<mozilla::HashMapEntry<long unsigned int, mozilla::Array<long unsigned int, 512>>, mozilla::HashMap<long unsigned int, mozilla::Array<long unsigned int, 512>, mozilla::DefaultHasher<long unsigned int>, js::SystemAllocPolicy>::MapHashPolicy, js::SystemAllocPolicy>]':
[task 2019-12-17T18:51:21.088Z] /builds/worker/workspace/build/src/obj-spider/dist/include/mozilla/HashTable.h:2053:21: required from 'mozilla::detail::HashTable<T, HashPolicy, AllocPolicy>::Ptr mozilla::detail::HashTable<T, HashPolicy, AllocPolicy>::lookup(const Lookup&) const [with T = mozilla::HashMapEntry<long unsigned int, mozilla::Array<long unsigned int, 512>>; HashPolicy = mozilla::HashMap<long unsigned int, mozilla::Array<long unsigned int, 512>, mozilla::DefaultHasher<long unsigned int>, js::SystemAllocPolicy>::MapHashPolicy; AllocPolicy = js::SystemAllocPolicy; mozilla::detail::HashTable<T, HashPolicy, AllocPolicy>::Lookup = long unsigned int]'
[task 2019-12-17T18:51:21.088Z] /builds/worker/workspace/build/src/obj-spider/dist/include/mozilla/HashTable.h:239:32: required from 'mozilla::HashMap<Key, Value, HashPolicy, AllocPolicy>::Ptr mozilla::HashMap<Key, Value, HashPolicy, AllocPolicy>::lookup(const Lookup&) const [with Key = long unsigned int; Value = mozilla::Array<long unsigned int, 512>; HashPolicy = mozilla::DefaultHasher<long unsigned int>; AllocPolicy = js::SystemAllocPolicy; mozilla::HashMap<Key, Value, HashPolicy, AllocPolicy>::Ptr = mozilla::detail::HashTable<mozilla::HashMapEntry<long unsigned int, mozilla::Array<long unsigned int, 512>>, mozilla::HashMap<long unsigned int, mozilla::Array<long unsigned int, 512>*, mozilla::DefaultHasher<long unsigned int>, js::SystemAllocPolicy>::MapHashPolicy, js::SystemAllocPolicy>::Ptr; mozilla::HashMap<Key, Value, HashPolicy, AllocPolicy>::Lookup = long unsigned int]'
[task 2019-12-17T18:51:21.088Z] /builds/worker/workspace/build/src/js/src/ds/Bitmap.h:98:38: required from here

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Generic code, oh well :-)