Closed Bug 1604606 Opened 4 months ago Closed 3 months ago

crashreporter_gtk_common.{h,cpp}: redundant 'SaveSettings' declaration

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: Sylvestre, Assigned: manish.giri.me, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Assignee: nobody → manish.giri.me
Status: NEW → ASSIGNED

Possible noob question about Mercurial - this change shouldn't 'depend' on another change, and yet, it appears there is a listed dependency on a change I had submitted just before this one.
My workflow was -

  1. Make the change for issue 'A', commit it using hg commit, submit it using moz-phab
  2. Repeat step 1 for changes for issues B, C and D
  3. However, each time I submitted my changes for issues B, C and D, it still picked up the previous/already submitted change, and tried to "update" it, before creating a new "revision" in Phabricator, for the current change in question.

Is there a way I can start working on an issue afresh after submitting a change for a previous issue, so this "dependency" does not occur? I was told in #irc that 'hg up tip -C' should reset(?) the current working directory, but that didn't seem to work in this case.

Either you delete locally patches (hg histedit and drop) or you remove by hand the dependency in phabricator

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/73bf88f9fca7
Remove redundant function declaration in cpp file. r=sylvestre
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.