1604606 - crashreporter_gtk_common.{h,cpp}: redundant 'SaveSettings' declaration

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

The SaveSettings() functions is declared twice. We should have only one declaration
https://searchfox.org/mozilla-central/source/toolkit/crashreporter/client/crashreporter_gtk_common.h#47
https://searchfox.org/mozilla-central/source/toolkit/crashreporter/client/crashreporter_gtk_common.cpp#60

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-declaration.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[Manish Giri]

Attachment: Bug 1604606 - Remove redundant function declaration in cpp file. r=sylvestre

Depends on D58228

Comment 2

[Manish Giri]

Possible noob question about Mercurial - this change shouldn't 'depend' on another change, and yet, it appears there is a listed dependency on a change I had submitted just before this one.
My workflow was -

1. Make the change for issue 'A', commit it using hg commit, submit it using moz-phab
2. Repeat step 1 for changes for issues B, C and D
3. However, each time I submitted my changes for issues B, C and D, it still picked up the previous/already submitted change, and tried to "update" it, before creating a new "revision" in Phabricator, for the current change in question.

Is there a way I can start working on an issue afresh after submitting a change for a previous issue, so this "dependency" does not occur? I was told in #irc that 'hg up tip -C' should reset(?) the current working directory, but that didn't seem to work in this case.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Either you delete locally patches (hg histedit and drop) or you remove by hand the dependency in phabricator

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73bf88f9fca7
Remove redundant function declaration in cpp file. r=sylvestre

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/73bf88f9fca7