Closed Bug 1604612 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 20817 - Speculative fix for xrSession_rAF_getViewerPose flakiness

Categories

(Core :: WebVR, task, P4)

Product:
Core
Component:
WebVR
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20817 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20817
Details from upstream follow.

Alex Cooper <alcooper@chromium.org> wrote:

Speculative fix for xrSession_rAF_getViewerPose flakiness

Failure cases for this test indicate that no pose was set. It seems
fairly likely that the failure cases are due to a race condition where
frame data is finished being processed by the time that the actual
frame data has been set. The webxr-test-api backs this up as a best
practice, saying that data is only guaranteed in the next frame if a
request has not yet been queued up.

Fixed:1034841
Change-Id: I3b35135bc01395a5cef896a5761dfbc13ecd6281
Reviewed-on: https://chromium-review.googlesource.com/1972256
WPT-Export-Revision: f4a4b9ec26ef710c915b7017632cc2bd36d0be11

Component: web-platform-tests → WebVR
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

FAIL : 1
ERROR : 1
NOTRUN: 1

Chrome

FAIL : 1
ERROR : 1
NOTRUN: 1

Safari

FAIL : 1
ERROR : 1
NOTRUN: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html: ERROR [Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: ERROR, Safari: ERROR)
XRFrame getViewerPose updates on the next frame for non-immersive sessions: FAIL (Chrome: FAIL, Safari: FAIL)
XRFrame getViewerPose updates on the next frame for immersive sessions: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)

Tests Disabled in Gecko Infrastructure

/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html: ERROR [Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: ERROR, Safari: ERROR)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

FAIL : 1
ERROR : 1
NOTRUN: 1

Chrome

FAIL : 1
ERROR : 1
NOTRUN: 1

Safari

FAIL : 1
ERROR : 1
NOTRUN: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html: ERROR [Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: ERROR, Safari: ERROR)
XRFrame getViewerPose updates on the next frame for non-immersive sessions: FAIL (Chrome: FAIL, Safari: FAIL)
XRFrame getViewerPose updates on the next frame for immersive sessions: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)

Tests Disabled in Gecko Infrastructure

/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html: ERROR [Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: ERROR, Safari: ERROR)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

FAIL : 1
ERROR : 1
NOTRUN: 1

Chrome

FAIL : 1
ERROR : 1
NOTRUN: 1

Safari

FAIL : 1
ERROR : 1
NOTRUN: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html: ERROR [Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: ERROR, Safari: ERROR)
XRFrame getViewerPose updates on the next frame for non-immersive sessions: FAIL (Chrome: FAIL, Safari: FAIL)
XRFrame getViewerPose updates on the next frame for immersive sessions: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)

Tests Disabled in Gecko Infrastructure

/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html: ERROR [Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: ERROR, Safari: ERROR)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7947291e045
[wpt PR 20817] - Speculative fix for xrSession_rAF_getViewerPose flakiness, a=testonly

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

FAIL : 1
ERROR : 1
NOTRUN: 1

Chrome

FAIL : 1
ERROR : 1
NOTRUN: 1

Safari

FAIL : 1
ERROR : 1
NOTRUN: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html: ERROR [Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: ERROR, Safari: ERROR)
XRFrame getViewerPose updates on the next frame for non-immersive sessions: FAIL (Chrome: FAIL, Safari: FAIL)
XRFrame getViewerPose updates on the next frame for immersive sessions: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)

Tests Disabled in Gecko Infrastructure

/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html: ERROR [Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: ERROR, Safari: ERROR)

Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/e7947291e045

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.