1604622 - webgl_gpgpu_protoplanet broken on Android (RGBA32F not renderable?)

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Guillaume Fradin]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

Go to the following threejs example:
https://threejs.org/examples/?q=gpu#webgl_gpgpu_protoplanet

Actual results:

The canvas remains black on Firefox for Android.

The console displays the following message:
THREE.WebGLRenderer: WEBGL_draw_buffers extension not supported.
Error: WebGL warning: clear: Framebuffer not complete. (status: 0x8cd6) Bad status according to the driver: 0x8cd6
Error: WebGL warning: clear: Framebuffer must be complete.

Expected results:

You should see particles orbiting each other (it works fine on Firefox for Desktop, tested on Ubuntu)

See the issue discussed on Github Threejs repo: https://github.com/mrdoob/three.js/issues/18177

Comment 1

[Laurentiu Apahidean]

I have managed to reproduce the issue on Release 68.3.0 and Beta 68.4b2, I will set this issue as new.
The issue also occurs on Firefox Preview, https://github.com/mozilla-mobile/fenix/issues/7269 was submitted regarding this.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Jeff, what are your thoughts on this one?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Jeff Gilbert is better person to take a look. WEBGL_draw_buffers extension isn't supported in Fenix or Chrome but doesn't seem needed for the demo because it runs fine in Chrome.

Comment 4

[Kelsey Gilbert [:jgilbert]]

I bet it's an RGB8 framebuffer, or something unguaranteed like that.

Comment 5

[Kelsey Gilbert [:jgilbert]]

0x8cd6 is INCOMPLETE_ATTACHMENT.
All framebuffers are RGBA/FLOAT.

Comment 6

[Kelsey Gilbert [:jgilbert]]

It looks like float32 render-to-texture is broken here. I can repro on my Essential PH-1.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1604622 - Use float16/float32 sized formats on es3+.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e5750541f2d
Use float16/float32 sized formats on es3+. r=lsalzman

Comment 9

[Dorel Luca [:dluca]]

Backed out changeset 1e5750541f2d (bug 1604622) for Mochitest failures in dom/canvas/test/webgl-conf/generated/test_conformance__extensions__oes-texture-float.html

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282689437&repo=autoland&lineNumber=2318

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=1e5750541f2d81237ba4670d59ba167c9f2e0e00

Backout:
https://hg.mozilla.org/integration/autoland/rev/10dc7e516ef1a6d27ba0cc64ce5af22ff0bf8e06

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b677d878830
Use float16/float32 sized formats on es3+. r=lsalzman

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6b677d878830

Comment 12

[Laurentiu Apahidean]

I have tested the issue on the latest Firefox Preview Nightly (Build #20030608) GV: 73.0a1-20191231094349 using a OnePlus 6T (Android 9) and a Pixel 3a XL (Android 10) and the issue no longer occurs.