Closed Bug 1604627 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 20818 - Exclude atomic inlines from LayoutInline::CollectLineBoxRects

Categories

(Core :: DOM: CSS Object Model, task, P4)

Product:
Core
Component:
DOM: CSS Object Model
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20818 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20818
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

Exclude atomic inlines from LayoutInline::CollectLineBoxRects

This patch fixes |LayoutInline::CollectLineBoxRects| not to
include atomic inlines.

Before r706815 \<crrev.com/c/1862534>, atomic inlines were
excluded in |NGPhysicalFragmentCollectorBase::
CollectInclusivelyFrom| by checking |NGPhysicalFragment::
IsBlockFormattingContextRoot()|, but the CL did not include
the check.

Because other |IsBlockFormattingContextRoot()| (floats and
out-of-flow objects) are already excluded, this patch adds
|IsAtomicInlineLevel| to the exclusion criteria.

Bug: 1032916
Change-Id: Idec83e1d8a5aa4de6ff40e723c6afbd41994b1b9

Reviewed-on: https://chromium-review.googlesource.com/1971633
WPT-Export-Revision: 982b767b5f6362343935350e10592d87090dd347

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PASS: 3

Chrome

OK : 1
PASS: 1
FAIL: 2

Safari

OK : 1
PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PASS: 3

Chrome

OK : 1
PASS: 1
FAIL: 2

Safari

OK : 1
PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bbc732281c41
[wpt PR 20818] - Exclude atomic inlines from LayoutInline::CollectLineBoxRects, a=testonly

https://hg.mozilla.org/mozilla-central/rev/bbc732281c41

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.