Closed Bug 1604628 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 20819 - [EventTiming] Fix crossiframe test

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox73 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20819 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20819
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

[EventTiming] Fix crossiframe test

This CL does the following fixes to crossiframe.html test:

  • Remove slow-image and onload, which are obsolete assumptions.
    Instead, rely solely on PerformanceObserver.
  • Use awaits where needed to make the test logic more sequential.
  • Use coordinates and test_driver.Actions() to target the iframe. Using
    the test_driver.click directly won't work for elements in iframes.
  • Updates the test to check reasonable values for the frame and iframe
    entries and check that they don't receive each other's entries.

This CL also:

  • Removes unneeded variables from the clickAndBlockMain().
  • Removes manual test, which is no longer needed.

Bug: 831729
Change-Id: Iff50035a216b21f67cd71796023af4f934573086
Reviewed-on: https://chromium-review.googlesource.com/1972249
WPT-Export-Revision: 7ca73b2272bcf3b82a231538abc781a254aa28cf

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 1 subtests

Status Summary

Firefox

OK : 8
FAIL : 8
PRECONDITION_FAILED: 1
TIMEOUT : 1

Chrome

OK : 3
PASS : 2
FAIL : 1
TIMEOUT : 12

Safari

OK : 8
FAIL : 8
PRECONDITION_FAILED: 1
TIMEOUT : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/event-timing/click-timing.html
Event Timing: compare click timings.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/crossiframe.html: PRECONDITION_FAILED (Chrome: TIMEOUT, Safari: PRECONDITION_FAILED)
Event Timing: entries should only be observable by its own frame.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
/event-timing/retrievability.html
Event Timing: make sure event-timing entries are not retrievable by performance.getEntries*.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/programmatic-click-not-observed.html
Event Timing: events from programmatic click are not observed: FAIL (Chrome: PASS, Safari: FAIL)
/event-timing/retrieve-firstInput.html
Event Timing: check first-input after onload, observer, click, click.: FAIL (Chrome: FAIL, Safari: FAIL)
/event-timing/only-observe-firstInput.html
Event Timing: check first-input for a PerformanceObserver observing only first-input.: FAIL (Chrome: PASS, Safari: FAIL)
/event-timing/buffered-flag.html
PerformanceObserver with buffered flag sees previous Event Timing entries: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/timingconditions.html
Event Timing only times certain types of trusted event.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/toJSON.html
Test toJSON() in PerformanceEventTiming.: FAIL (Chrome: TIMEOUT, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 1 subtests

Status Summary

Firefox

OK : 8
FAIL : 8
PRECONDITION_FAILED: 1
TIMEOUT : 1

Chrome

OK : 3
PASS : 2
FAIL : 1
TIMEOUT : 12

Safari

OK : 8
FAIL : 8
PRECONDITION_FAILED: 1
TIMEOUT : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/event-timing/click-timing.html
Event Timing: compare click timings.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/crossiframe.html: PRECONDITION_FAILED (Chrome: TIMEOUT, Safari: PRECONDITION_FAILED)
Event Timing: entries should only be observable by its own frame.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
/event-timing/retrievability.html
Event Timing: make sure event-timing entries are not retrievable by performance.getEntries*.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/programmatic-click-not-observed.html
Event Timing: events from programmatic click are not observed: FAIL (Chrome: PASS, Safari: FAIL)
/event-timing/retrieve-firstInput.html
Event Timing: check first-input after onload, observer, click, click.: FAIL (Chrome: FAIL, Safari: FAIL)
/event-timing/only-observe-firstInput.html
Event Timing: check first-input for a PerformanceObserver observing only first-input.: FAIL (Chrome: PASS, Safari: FAIL)
/event-timing/buffered-flag.html
PerformanceObserver with buffered flag sees previous Event Timing entries: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/timingconditions.html
Event Timing only times certain types of trusted event.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/toJSON.html
Test toJSON() in PerformanceEventTiming.: FAIL (Chrome: TIMEOUT, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 1 subtests

Status Summary

Firefox

OK : 8
FAIL : 8
PRECONDITION_FAILED: 1
TIMEOUT : 1

Chrome

OK : 3
PASS : 2
FAIL : 1
TIMEOUT : 12

Safari

OK : 8
FAIL : 8
PRECONDITION_FAILED: 1
TIMEOUT : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/event-timing/click-timing.html
Event Timing: compare click timings.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/crossiframe.html: PRECONDITION_FAILED (Chrome: TIMEOUT, Safari: PRECONDITION_FAILED)
Event Timing: entries should only be observable by its own frame.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
/event-timing/retrievability.html
Event Timing: make sure event-timing entries are not retrievable by performance.getEntries*.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/programmatic-click-not-observed.html
Event Timing: events from programmatic click are not observed: FAIL (Chrome: PASS, Safari: FAIL)
/event-timing/retrieve-firstInput.html
Event Timing: check first-input after onload, observer, click, click.: FAIL (Chrome: FAIL, Safari: FAIL)
/event-timing/only-observe-firstInput.html
Event Timing: check first-input for a PerformanceObserver observing only first-input.: FAIL (Chrome: PASS, Safari: FAIL)
/event-timing/buffered-flag.html
PerformanceObserver with buffered flag sees previous Event Timing entries: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/timingconditions.html
Event Timing only times certain types of trusted event.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/toJSON.html
Test toJSON() in PerformanceEventTiming.: FAIL (Chrome: TIMEOUT, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce9050847bad
[wpt PR 20819] - [EventTiming] Fix crossiframe test, a=testonly
https://hg.mozilla.org/integration/autoland/rev/338a7fd63bc4
[wpt PR 20819] - Update wpt metadata, a=testonly

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 1 subtests

Status Summary

Firefox

OK : 8
FAIL : 8
PRECONDITION_FAILED: 1
TIMEOUT : 1

Chrome

OK : 3
PASS : 2
FAIL : 1
TIMEOUT : 12

Safari

OK : 8
FAIL : 8
PRECONDITION_FAILED: 1
TIMEOUT : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/event-timing/click-timing.html
Event Timing: compare click timings.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/crossiframe.html: PRECONDITION_FAILED (Chrome: TIMEOUT, Safari: PRECONDITION_FAILED)
Event Timing: entries should only be observable by its own frame.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
/event-timing/retrievability.html
Event Timing: make sure event-timing entries are not retrievable by performance.getEntries*.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/programmatic-click-not-observed.html
Event Timing: events from programmatic click are not observed: FAIL (Chrome: PASS, Safari: FAIL)
/event-timing/retrieve-firstInput.html
Event Timing: check first-input after onload, observer, click, click.: FAIL (Chrome: FAIL, Safari: FAIL)
/event-timing/only-observe-firstInput.html
Event Timing: check first-input for a PerformanceObserver observing only first-input.: FAIL (Chrome: PASS, Safari: FAIL)
/event-timing/buffered-flag.html
PerformanceObserver with buffered flag sees previous Event Timing entries: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/timingconditions.html
Event Timing only times certain types of trusted event.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/toJSON.html
Test toJSON() in PerformanceEventTiming.: FAIL (Chrome: TIMEOUT, Safari: FAIL)

https://hg.mozilla.org/mozilla-central/rev/ce9050847bad
https://hg.mozilla.org/mozilla-central/rev/338a7fd63bc4

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.