Closed
Bug 1604829
Opened 4 years ago
Closed 4 years ago
Mark count calculation is wrong in GCMarker::mark
Categories
(Core :: JavaScript: GC, defect, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla74
People
(Reporter: jonco, Assigned: allstars.chh)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
The calculation of how many cells we mark is wrong because it is incremented whenever we touch a cell, regardless of whether that cell was already marking. I should have spotted this in code review I guess.
markCount++;
return cell->markIfUnmarked(color);
We only want to increment the counter if markIfUnmarked() returns true, otherwise we will overcount.
Updated•4 years ago
|
Keywords: regression
Comment 1•4 years ago
|
||
The priority flag is not set for this bug.
:jonco, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(jcoppeard)
Reporter | ||
Updated•4 years ago
|
Flags: needinfo?(jcoppeard)
Priority: -- → P3
Reporter | ||
Comment 2•4 years ago
|
||
Yoshi, can you take a look at this when you get a chance?
Flags: needinfo?(allstars.chh)
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → allstars.chh
Flags: needinfo?(allstars.chh)
Assignee | ||
Comment 3•4 years ago
|
||
Pushed by allstars.chh@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a9b4a0406243 Increment mark count only when the cell is marked. r=jonco
Comment 5•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Comment 6•4 years ago
|
||
Is there a user impact here which justifies backport consideration or can this fix ride Fx74 to release?
status-firefox72:
--- → wontfix
status-firefox73:
--- → fix-optional
status-firefox-esr68:
--- → wontfix
Flags: needinfo?(allstars.chh)
Reporter | ||
Comment 7•4 years ago
|
||
Nope, this only affects telemetry.
Reporter | ||
Updated•4 years ago
|
Flags: needinfo?(allstars.chh)
Updated•4 years ago
|
Updated•4 years ago
|
Has Regression Range: --- → yes
Comment hidden (spam) |
Comment hidden (spam) |
Comment hidden (spam) |
Comment hidden (spam) |
Reporter | ||
Updated•1 year ago
|
Flags: needinfo?(jcoppeard)
You need to log in
before you can comment on or make changes to this bug.
Description
•