Closed Bug 1604950 Opened 7 months ago Closed 6 months ago

Remove xpidl [array] use in nsIMsgMessageService

Categories

(MailNews Core :: Backend, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 73.0

People

(Reporter: benc, Assigned: benc)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → benc
Comment on attachment 9117598 [details] [diff] [review]
1604950-xpidl-array-removal-in-nsIMsgMessageService-1.patch

Review of attachment 9117598 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, modulo the const placements. r=mkmelin

::: mailnews/base/public/nsIMsgMessageService.idl
@@ +56,5 @@
>     * @param aUrlListener
>     * @param aMsgWindow
>     * @returns URI that's run to perform the copy
>     */
> +  nsIURI CopyMessages(in Array<nsMsgKey> aKeys,

change to copyMessages while where here
Attachment #9117598 - Flags: review?(mkmelin+mozilla) → review+
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 73.0

Just makes the <blah> const & => const <blah> & changes.
I left CopyMessages() named as is - there are about 6 other methods in the same boat, so I punted it off to Bug 1606272.

Attachment #9117598 - Attachment is obsolete: true
Attachment #9118005 - Flags: review+
Blocks: 1551704

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/97cfef598a76
Remove xpidl [array] use in nsIMsgMessageService. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.