160497 - problem formatting short date when date=0

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[ajbu]

From newsgroup, reported by Peter Lairo
When setting pref to short date, dateUtils calls:
      return( dateService.FormatDate( "", dateService.dateFormatShort, 
date.getFullYear(), date.getMonth()+1, date.getDate() ) );

New tasklist tries to format all date-fields, including completed, sometimes 
not set (date = 0/0/0...)

FormatDate doesn't handle dates < 1800, Year==0 gives an error.
So, there must be a check that only 'valid'/recent dates are processed by 
FormatDate. Note that dtstart/dtdue might also be 0?


ERROR:
****************************+
Error: [Exception... "Component returned failure code: 0x80070057 
(NS_ERROR_ILLEGAL_VALUE) [nsIScriptableDateFormat.FormatDate]" 
nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: 
chrome://calendar/content/dateUtils.js :: anonymous :: line 119"  data: no]
Source File: chrome://calendar/content/dateUtils.js
Line: 119
****************************+

Error: [Exception... "Component returned failure code: 0x80070057 
(NS_ERROR_ILLEGAL_VALUE) [nsIScriptableDateFormat.FormatDate]" 
nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: 
chrome://calendar/content/dateUtils.js :: anonymous :: line 119"  data: no]
Source File: chrome://calendar/content/dateUtils.js
Line: 119
****************************+

Comment 1

[ajbu]

I'll do this with bug 160513, hope to make a patch after lunch

Comment 2

[Brant Gurganus]

Since this patch was within the patch for bug 160513, I am setting a dependency.

Comment 3

[Mike Potter]

This is fixed in CVS.

Comment 4

[Brant Gurganus]

Verified in 2002103116-cal Win XP SP1, Moz 2002102415

Comment 5

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!