1605027 - JsWindowActor based Frame target uses the wrong docShell for frames

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

The FrameTargetActor currently retrieves its docShell from the "chromeGlobal" argument passed to the constructor.

For a top level frame target initialized via frame-connector.js (message-manager based), the chromeGlobal is the content message manager of the frame.js script. The docShell of this message manager is the docShell corresponding to the frame.

However for a remote frame, we currently fetch the message manager as follows:

    // Create the actual target actor.
    const { messageManager } = this.docShell;
    const targetActor = new FrameTargetActor(connection, messageManager);

this is the DevTools frame JsWindowActor. Here this.docShell is the correct docShell for the frame, however, this.docShell.messageManager seem to be the message manager of the parent frame, and therefore this.docShell.messageManager.docShell != this.docShell.

We should explicitly pass the docShell as a constructor argument to the frame target to avoid this issue.

This was one of the problems mentioned in Bug 1600612.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1605027 - Create remote FrameTargetActor with the correct docShell

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1605027 - Update listRemoteFrames API to only return remote frames or remote browsers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00f9b55d3ac3
Create remote FrameTargetActor with the correct docShell r=ochameau

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/00f9b55d3ac3