Closed Bug 1605066 Opened 2 years ago Closed 2 years ago

Don't track property types for non-singleton environment objects

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(2 files)

The JITs don't use these types so it's just unnecessary work.

I have a patch to tidy up environment object allocation to go through a single function, and then we can easily make this change on top of that.

Ion is only interested in the global lexical environment, a singleton. Don't
waste time tracking property types for other environments.

Depends on D57776

Priority: -- → P1
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/404d35386c05
part 1 - Tidy up and de-duplicate environment object allocation code. r=jonco
https://hg.mozilla.org/integration/autoland/rev/ee35112c00d1
part 2 - Don't track property types for non-singleton environment objects. r=jonco
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73

== Change summary for alert #24566 (as of Fri, 20 Dec 2019 22:14:47 GMT) ==

Improvements:

3% Base Content JS macosx1014-64-shippable opt 3,841,908.00 -> 3,732,358.00
3% Base Content JS windows10-64-shippable opt 3,903,856.00 -> 3,793,289.33
3% Base Content JS windows10-64-shippable-qr opt 3,903,813.33 -> 3,793,342.67
3% Base Content JS linux64 opt 3,836,689.33 -> 3,729,194.00
3% Base Content JS linux64-qr opt 3,836,716.00 -> 3,729,408.67
3% Base Content JS linux64-shippable opt 3,836,716.00 -> 3,729,354.00
3% Base Content JS linux64-shippable-qr opt 3,836,732.00 -> 3,729,267.33
3% Base Content JS windows10-64 opt 3,899,684.00 -> 3,792,622.67
3% Base Content JS windows10-64-qr opt 3,899,709.33 -> 3,792,586.67
2% Base Content JS windows7-32 opt 3,002,032.47 -> 2,943,174.00
2% Base Content JS windows7-32-shippable opt 3,002,039.06 -> 2,943,175.33

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24566

You need to log in before you can comment on or make changes to this bug.