1605102 - Always ask what to do for text/plain mimetype combined with ApplicationReputation file extensions (and disable/hide the checkbox in this case)

Status: RESOLVED FIXED

(Firefox :: File Handling, task, P1)

Description

[:Gijs (he/him)]

See bug 1568003 comment 62.

Given the nature of text/plain, I believe the existing code at https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/uriloader/exthandler/nsExternalHelperAppService.cpp#1658-1663 is currently sufficient, but we are likely to want to adjust some of this if/when we fix bug 453455, so having an explicit check here seems prudent.

Keeping this hidden as long as bug 1568003 is.

Comment 1

[:Gijs (he/him)]

... and of course, we should also not allow users to save this preference - they will just be disappointed in future.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1605102, r?mak!,dimi!

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1605102 pt 2, r?mak

Depends on D58674

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/9b4df8ced46a9dcc9ec1de1fce409bf9e8affb67
https://hg.mozilla.org/integration/autoland/rev/c8c437b5e3ef927029148aa4f33f7a0cad933f16
https://hg.mozilla.org/mozilla-central/rev/9b4df8ced46a
https://hg.mozilla.org/mozilla-central/rev/c8c437b5e3ef

Comment 5

[:Gijs (he/him)]

I still need to file a follow-up for tests.

Comment 6

[:Gijs (he/him)]

Given the regressions from the other bug, let's not try and uplift this into 73, even though I think one of the patches here currently makes 0 practical difference.

Comment 7

[:Gijs (he/him)]

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1613935