1605123 - Assertion failure: mKeyword == CSP_UNSAFE_INLINE (should only invalidate unsafe-inline), at /builds/worker/workspace/build/src/dom/security/nsCSPUtils.cpp:845

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P1)

Description

[Bob Clary [:bc] (inactive)]

1. https://www.pinterest.ca/lorileeee/ + 85 other urls so far
2. Assertion Nightly Linux/Windows but not Beta.

This looks like a recent regression.

Assertion failure: mKeyword == CSP_UNSAFE_INLINE (should only invalidate unsafe-inline), at /builds/worker/workspace/build/src/dom/security/nsCSPUtils.cpp:845
#01: nsCSPDirective::allows(CSPKeyword, nsTSubstring<char16_t> const&, bool) const [dom/security/nsCSPUtils.cpp:1052]
#02: nsCSPPolicy::allows(unsigned int, CSPKeyword, nsTSubstring<char16_t> const&, bool) const [dom/security/nsCSPUtils.cpp:0]
#03: nsCSPContext::GetAllowsInline(unsigned int, nsTSubstring<char16_t> const&, bool, mozilla::dom::Element*, nsICSPEventListener*, nsTSubstring<char16_t> const&, unsigned int, unsigned int, bool*) [dom/security/nsCSPContext.cpp:550]
#04: mozilla::dom::ScriptLoader::ProcessInlineScript(nsIScriptElement*, mozilla::dom::ScriptKind) [dom/script/ScriptLoader.cpp:1782]
#05: mozilla::dom::ScriptLoader::ProcessScriptElement(nsIScriptElement*) [dom/script/ScriptLoader.cpp:1592]
#06: mozilla::dom::ScriptElement::MaybeProcessScript() [dom/script/ScriptElement.cpp:118]
#07: nsHtml5TreeOpExecutor::RunScript(nsIContent*) [parser/html/nsHtml5TreeOpExecutor.cpp:738]
#08: nsHtml5TreeOpExecutor::RunFlushLoop() [parser/html/nsHtml5TreeOpExecutor.cpp:544]
#09: nsHtml5ExecutorFlusher::Run() [parser/html/nsHtml5StreamParser.cpp:0]
#10: mozilla::SchedulerGroup::Runnable::Run() [xpcom/threads/SchedulerGroup.cpp:282]
#11: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1241]
#12: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:486]
#13: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:87]
#14: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
#15: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:139]
#16: XRE_RunAppShell() [toolkit/xre/nsEmbedFunctions.cpp:946]
#17: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:237]
#18: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
#19: XRE_InitChildProcess(int, char**, XREChildData const*) [toolkit/xre/nsEmbedFunctions.cpp:781]
#20: content_process_main(mozilla::Bootstrap*, int, char**) [ipc/contentproc/plugin-container.cpp:57]
#21: main [browser/app/nsBrowserApp.cpp:303]
#22: libc.so.6 + 0x23f43
#23: _start

Comment 1

[Jonathan Kingston [:jkt] he/him]

Almost certain this was me with Bug 1603709

Comment 2

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1605123 - Fix CSP keyword invalidation assertion crash. r?ckerschb

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbef22fa266a
Fix CSP keyword invalidation assertion crash. r=ckerschb

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/bbef22fa266a