Differentiate fission-enabled vs non-fission enabled talos data in perfherder
Categories
(Testing :: Talos, defect, P1)
Tracking
(Fission Milestone:M5, firefox73 fixed)
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: rwood, Assigned: rwood)
References
Details
Attachments
(1 file)
We are running talos on Firefox with fission enabled in CI now on central i.e. [0]. The taskcluster job name has '-fis' attached for each test job as expected. However, for the test names in the PERFHERDER_DATA output we are using the regular talos test names i.e.:
[task 2019-12-19T11:25:10.408Z] 11:25:10 INFO - PERFHERDER_DATA: {"framework": {"name": "talos"}, "suites": [{"extraOptions": ["e10s", "stylo"], "name": "tabswitch",
This is causing the fission-enabled results to be combined with non-fission results in Perfherder. For the talos fisison tests we need to add '-fis' to the end of the test name in PERFHERDER data in order to differentiate.
Thanks for reporting this issue :mconley!
|
Assignee | |
Comment 1•4 years ago
|
||
Actually I think we can just add 'fis' to the 'extraOptions' and that will cause Perfherder to differentiate.
:igoldan, am I correct here?
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
|
Assignee | |
Comment 4•4 years ago
•
|
||
You'll see this adds 'fis' to extraOptions when running talos with '--enable-fission':
16:36:08 INFO - PERFHERDER_DATA: {"framework": {"name": "talos"}, "suites": [{"extraOptions": ["e10s", "stylo", "fis"],
|
|
Assignee | |
Comment 5•4 years ago
|
||
(In reply to Robert Wood [:rwood] from comment #4)
You'll see this adds 'fis' to extraOptions when running talos with '--enable-fission':
16:36:08 INFO - PERFHERDER_DATA: {"framework": {"name": "talos"}, "suites": [{"extraOptions": ["e10s", "stylo", "fis"],
Hmm ^ is when run locally, but on my try push (comment 3) it's not adding it, so let me have a look again...
[task 2019-12-19T17:41:49.606Z] 17:41:49 INFO - PERFHERDER_DATA: {"framework": {"name": "talos"}, "suites": [{"extraOptions": ["e10s", "stylo"],
|
|
Assignee | |
Comment 6•4 years ago
|
||
When running talos fission in production, enable_fission is False for some reason, but the prefs are still being set:
[task 2019-12-19T17:34:08.223Z] 17:34:08 INFO - 'enable_fission': False,
[task 2019-12-19T17:34:08.223Z] 17:34:08 INFO - 'enable_webrender': False,
[task 2019-12-19T17:34:08.223Z] 17:34:08 INFO - 'extra_prefs': ('fission.autostart=true',
[task 2019-12-19T17:34:08.223Z] 17:34:08 INFO - 'dom.serviceWorkers.parent_intercept=true',
[task 2019-12-19T17:34:08.223Z] 17:34:08 INFO - 'browser.tabs.documentchannel=true',
[task 2019-12-19T17:34:08.223Z] 17:34:08 INFO - 'media.peerconnection.mtransport_process=false',
[task 2019-12-19T17:34:08.223Z] 17:34:08 INFO - 'network.process.enabled=false'),
|
|
Assignee | |
Comment 7•4 years ago
•
|
||
Ok figured it out, the taskcluster transform adds the extra fission prefs when the fission variant is running. We need to check for those extra prefs and then set fission_enabled internally in talos based on that. That's how it is done in raptor which doesn't have this issue:
|
|
Assignee | |
Comment 9•4 years ago
|
||
|
|
Assignee | |
Comment 10•4 years ago
|
||
|
|
Assignee | |
Comment 11•4 years ago
|
||
(In reply to Robert Wood [:rwood] from comment #10)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c74f280898161a5aa575f65991dc99fbc1e3770c
Ok much better in CI:
[task 2019-12-19T20:36:46.012Z] 20:36:46 INFO - PERFHERDER_DATA: {"framework": {"name": "talos"}, "suites": [{"extraOptions": ["e10s", "stylo", "fission"],
|
|
Assignee | |
Comment 12•4 years ago
|
||
|
||
Comment 13•4 years ago
|
||
Pushed by rwood@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e70a4f7271bb Differentiate fission-enabled vs non-fission enabled talos data in perfherder r=perftest-reviewers,stephendonner
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 14•4 years ago
|
||
| bugherder | ||
Description
•