Closed Bug 1605243 Opened 5 years ago Closed 4 years ago

[Fission] Make nsDocShell::SetCustomUserAgent Fission compatible

Categories

(Core :: DOM: Navigation, defect, P3)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Project Flags:
Fission Milestone M6
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: whimboo, Assigned: mattwoodrow)

References

Details

While chatting with Mike Conley about docShell.customUserAgent and how it propagates the custom value to frames we noticed that it is not Fission compatible:

https://searchfox.org/mozilla-central/rev/b243debf6235b050b42fd2eb615fdc729636ca6b/docshell/base/nsDocShell.cpp#2361-2367

whimboo> shouldn't we fix that in docshell so that it keeps its current behavior?
<mconley> whimboo: yes, probably? Or this should be moved out of DocShell entirely
<mconley> and made into something that the BrowsingContext tree manages
Flags: needinfo?(afarre)

Tracking for Fission Nightly (M6)

Fission Milestone: --- → M6
Priority: -- → P3

I seem this has been fixed in bug 1615967

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Yes, that works great. Thanks!

Assignee: nobody → matt.woodrow
status-firefox75: --- → fixed
Flags: needinfo?(afarre)
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.