Closed Bug 1605349 Opened 6 years ago Closed 6 years ago

Fix expectation for marker-content-010.html WPT test

Categories

(Core :: Layout: Generated Content, Lists, and Counters, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: Oriol, Assigned: Oriol)

Details

Attachments

(1 file)

https://wpt.fyi/results/css/css-pseudo/marker-content-010.html is passing in Firefox just by chance, but the expectation is wrong so it fails in other browsers.

First, the test uses font: 16px/1 monospace but then the reference uses font-size:initial. The initial value is medium, which is UA-dependent. From https://drafts.csswg.org/css-fonts-4/#absolute-size-mapping,

The user agent may fine-tune these values for different fonts

So font-size:initial may be 16px in Firefox but in Chromium I get 13px for a monospace font.

Second, the reference sets line-height:0 to the fake marker. This prevents the fake marker from affecting the line height of the list item. However, https://drafts.csswg.org/css-lists/#list-style-position-outside says

The size or contents of the marker box may affect the height of the principal block box and/or the height of its first line box

In Firefox outside markers don't affect the line height, in Chromium they do, and since the spec says MAY, both are correct. But the test is enforcing the Firefox behavior.

Priority: -- → P3
Pushed by nerli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e50e25b0a22 Fix expectation for marker-content-010.html WPT test. r=mats,emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21226 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: