1605370 - Cleanup DevTools tests using ok() incorrectly

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

Tests in the codebase sometimes use ok() as an info() equivalent:

ok(true, "message");

Not ideal, but sometimes needed, if there are no other asserts in the test and not worth updating.

However we also have completely wrong usage of ok():
https://searchfox.org/mozilla-central/search?q=ok%5C(%5C%22%5B%5E%22%5D*%5C%22%5C)&case=true&regexp=true&path=

Here, ok() is only called with a string, eg ok("Manifest is being displayed");. This will count as a valid assertions, but in the logs this will show up as:

PASS undefined assertion name -

We should switch those to ok(true, "message") at least

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1605370 - Rewrite ok(message) as ok(true, message) in DevTools tests

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/021d07025dad
Rewrite ok(message) as ok(true, message) in DevTools tests r=daisuke

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/021d07025dad