[wpt-sync] Sync PR 20889 - [RFC] Refactor data-feeding for ImageDocument/ImageDocumentParser
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 20889 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/20889
Details from upstream follow.
Fredrik Söderquist <fs@opera.com> wrote:
[RFC] Refactor data-feeding for ImageDocument/ImageDocumentParser
ImageDocumentParser keeps the ImageResource for ImageDocument and passes
the associated ImageResourceContent to the HTMLImageElement used for the
ImageDocument.This eliminates ImageDocument::CachedImageResourceDeprecated and cleans
up ImageDocument\<->ImageDocumentParser interaction a bit.
The creation of the ImageResource now takes place in the first call to
ImageDocumentParser::AppendBytes rather than indirectly via a call to
ImageDocument::CachedImage.Set ImageLoader::image_complete_ in the same as for regular image-loads,
and start dispatching 'load' (and 'error') events for the \<img> element
in the image document. This behavior matches Gecko.Bug: 958339
Change-Id: Iacdab89f6894adf70163f0d5300aefc9b2fce4e8
Reviewed-on: https://chromium-review.googlesource.com/1975921
WPT-Export-Revision: cddaa5e5d4ebea3a420ffadf4c9bbe837a73021b
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=29db9c8cc8bdb8043a4345df90a882be0a89cee7
|
|
Assignee | |
Comment 2•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 3 tests and 1 subtests
Status Summary
Firefox
OK : 1
PASS : 3
TIMEOUT: 2
NOTRUN : 1
Chrome
CRASH : 1
FAIL : 1
TIMEOUT: 2
NOTRUN : 2
Safari
FAIL : 1
TIMEOUT: 4
NOTRUN : 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/html/semantics/embedded-content/the-img-element/decode/image-decode-iframe.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
HTMLImageElement.prototype.decode(), iframe tests. Decode from removed iframe fails (img not loaded): TIMEOUT (Chrome: NOTRUN, Safari: NOTRUN)
HTMLImageElement.prototype.decode(), iframe tests. Decode from iframe, later removed, fails (img not loaded): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
|
|
Assignee | |
Comment 3•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 3 tests and 1 subtests
Status Summary
Firefox
OK : 1
PASS : 3
TIMEOUT: 2
NOTRUN : 1
Chrome
CRASH : 1
FAIL : 1
TIMEOUT: 2
NOTRUN : 2
Safari
FAIL : 1
TIMEOUT: 4
NOTRUN : 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/html/semantics/embedded-content/the-img-element/decode/image-decode-iframe.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
HTMLImageElement.prototype.decode(), iframe tests. Decode from removed iframe fails (img not loaded): TIMEOUT (Chrome: NOTRUN, Safari: NOTRUN)
HTMLImageElement.prototype.decode(), iframe tests. Decode from iframe, later removed, fails (img not loaded): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
|
|
Assignee | |
Comment 4•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 3 tests and 1 subtests
Status Summary
Firefox
OK : 1
PASS : 3
TIMEOUT: 2
NOTRUN : 1
Chrome
CRASH : 1
FAIL : 1
TIMEOUT: 2
NOTRUN : 2
Safari
FAIL : 1
TIMEOUT: 4
NOTRUN : 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/html/semantics/embedded-content/the-img-element/decode/image-decode-iframe.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
HTMLImageElement.prototype.decode(), iframe tests. Decode from removed iframe fails (img not loaded): TIMEOUT (Chrome: NOTRUN, Safari: NOTRUN)
HTMLImageElement.prototype.decode(), iframe tests. Decode from iframe, later removed, fails (img not loaded): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7a1d92e2a3a1 [wpt PR 20889] - Refactor data-feeding for ImageDocument/ImageDocumentParser, a=testonly https://hg.mozilla.org/integration/autoland/rev/04dd59867d61 [wpt PR 20889] - Update wpt metadata, a=testonly
|
|
Assignee | |
Comment 6•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 3 tests and 1 subtests
Status Summary
Firefox
OK : 1
PASS : 3
TIMEOUT: 2
NOTRUN : 1
Chrome
CRASH : 1
FAIL : 1
TIMEOUT: 2
NOTRUN : 2
Safari
FAIL : 1
TIMEOUT: 4
NOTRUN : 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/html/semantics/embedded-content/the-img-element/decode/image-decode-iframe.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
HTMLImageElement.prototype.decode(), iframe tests. Decode from removed iframe fails (img not loaded): TIMEOUT (Chrome: NOTRUN, Safari: NOTRUN)
HTMLImageElement.prototype.decode(), iframe tests. Decode from iframe, later removed, fails (img not loaded): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7a1d92e2a3a1
https://hg.mozilla.org/mozilla-central/rev/04dd59867d61
Description
•