Port bug 1604960 Migrate all basic text actions l10n to Fluent
Categories
(Thunderbird :: General, task)
Tracking
(Not tracked)
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(2 files, 2 obsolete files)
|
7.08 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
|
38.82 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
When bug 1604960 lands, we need at least to fix common/src/viewSource.xul and mail/components/activity/content/activity.xul.
|
Assignee | |
Comment 1•4 years ago
|
||
This fixes the issues. I wait with the r? until the M-C patch is ready to land.
|
|
Assignee | |
Comment 2•4 years ago
|
||
This patch removes most cut/copy/paste etc strings from mail tree and uses the M-C textActions.ftl instead. I haven't removed all because they are used as valueDefault and I don't know how this could be fixed.
And in composer's subject text box the context menu shows no Languages menuitem.
|
|
Assignee | |
Comment 3•4 years ago
|
||
Patch updated after the xul to xhtml change. Also the M-C patch has r+.
|
|
Assignee | |
Comment 4•4 years ago
|
||
Updated to tip.
|
||
Comment 5•4 years ago
|
||
Comment on attachment 9117704 [details] [diff] [review] 1605480-text-actions-to-fluent.patch Review of attachment 9117704 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! r=mkmelin
|
|
||
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/c2543953fdf6
ug 1605480 - Port bug 1604960: Migrate all text actions to use Fluent. r=mkmelin
|
|
||
Comment 7•4 years ago
|
||
Squashed the patches for landing, and fixed the username header.
|
||
Comment 8•4 years ago
|
||
You mean "merged" or "folded" (hg qfold)? Or do you mean that you "squashed" away the leading "B" in the commit message, so you landed "ug 1605480"? :-( - A complete and intact commit message was present in both patches. May I suggest that you do "hg out" and carefully read what you're about to land in the future.
Anyway, Mochitests have failed almost completely.
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/ecf60bb15b46 Restore DTD for missing string in messageWindow.xhtml; rs=bustage-fix
Description
•