1605499 - [meta] Support Datadog usage of Puppeteer

Status: RESOLVED INCOMPLETE

(Remote Protocol :: Agent, task)

Description

[David Burns :automatedtester]

Attachment: log of puppeteer usage from

Datadog would like to support Firefox with puppeteer. Attached is a debug log of their usage.

This breaks down to
Events Recieved

{'Page.frameAttached': 17, 'Page.frameStoppedLoading': 22, 'Target.targetDestroyed': 1, 
'Target.targetInfoChanged': 7, 'Target.targetCreated': 3, 'Page.frameStartedLoading': 22, 
'Runtime.executionContextCreated': 46, 'Page.frameScheduledNavigation': 1, 
'Page.frameNavigated': 22, 'Network.requestWillBeSentExtraInfo': 225, 
'Network.requestServedFromCache': 4, 'Target.attachedToTarget': 1, 
'Target.detachedFromTarget': 1, 'Runtime.consoleAPICalled': 19, 'Page.frameDetached': 9, 
'Runtime.executionContextsCleared': 4, 'Network.resourceChangedPriority': 21, 
'Network.dataReceived': 437, 'Network.loadingFinished': 227, 
'Page.frameRequestedNavigation': 1, 'Log.entryAdded': 27, 'Page.lifecycleEvent': 190, 
'Page.domContentEventFired': 4, 'Page.frameClearedScheduledNavigation': 1, 
'Page.loadEventFired': 4, 'Network.requestWillBeSent': 229, 'Network.responseReceived': 227, 
'Runtime.executionContextDestroyed': 28, 'Fetch.requestPaused': 225, 
'Network.responseReceivedExtraInfo': 225}

Events Sent

{'Target.setDiscoverTargets': 1, 'Performance.enable': 1, 'Runtime.enable': 1, 'Page.enable': 2,
 'Network.getResponseBody': 4, 'Network.setCacheDisabled': 1, 'Fetch.enable': 1, 
'Page.getLayoutMetrics': 4, 'Page.addScriptToEvaluateOnNewDocument': 3, 
'Page.getFrameTree': 1, 'Browser.getVersion': 1, 'Emulation.setDeviceMetricsOverride': 1, 
'Page.close': 1, 'Page.captureScreenshot': 13, 'Target.attachToTarget': 1, 'Page.reload': 1, 
'DOM.getContentQuads': 4, 'Network.setExtraHTTPHeaders': 1, 'Runtime.getProperties': 2, 
'Fetch.continueRequest': 225, 'Page.setLifecycleEventsEnabled': 1, 'Runtime.releaseObject': 2, 
'Log.enable': 1, 'Network.enable': 1, 'Network.setUserAgentOverride': 1, 
'Page.setInterceptFileChooserDialog': 1, 'Target.setAutoAttach': 1, 'Page.createIsolatedWorld': 1,
 'Input.dispatchMouseEvent': 10, 'Runtime.callFunctionOn': 149, 'Page.navigate': 2, 
'Emulation.setTouchEmulationEnabled': 1}

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Do we actually know which of those events and methods still fail? Even having the meta bugs open, we have basic implementations for a lot of them which might fulfill their needs. It would be great to get them to run their tests with Firefox Nightly. Or where did you get the log from?

Comment 2

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #1)

Do we actually know which of those events and methods still fail? Even having the meta bugs open, we have basic implementations for a lot of them which might fulfill their needs.

It would probably be more appropriate for this bug to depend on the outstanding implementation bugs, which you are right is going to be a subset of the dependencies of those meta bugs.

But I understand finding that out takes a bit of time, so until we’ve deduced that from the debug logs I guess it’s informative to use the coarse list of meta bugs.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I had a quick look at the log and it doesn't show any UnknownMethodError, which means all the methods it needs are implemented. Also I cannot see any other error, so I wonder what's actually broken. David, which failures have you seen?

Comment 4

[David Burns :automatedtester]

This is their log when using Chrome, so I don't expect there to be any UnknownMethodErrors. Will ask the user if they can try it out and see what breaks for them. Looking at the dependency tree for this bug there looks like there are a number of "Implement" bugs that still need working on.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

All the requirements for Page.getFrameTree should be available now via bug 1605359.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I checked datadog and as of today I was not able to find any reference to Puppeteer. Not sure if the Puppeteer support was ever considered since this bug was filed. Because we do not have any reference I'm closing this bug.