1605575 - Find highlighted text is redrawn(flashing) each time when searching next / previous

Status: NEW

(Toolkit :: Find Toolbar, defect, P5)

Description

[Alice0775 White]

This is not a recent regression. At least I can reproduce with ESR52.

Reproducible: sometimes on certain web page

Steps To Reproduce:

1. Open https://en.wikipedia.org/wiki/Black_hole
2. Open Findbar (Ctrl+F)
3. Type "Black hole" in findbar
4. Turn on "Highlight All"
5. Crick previous button in findbar and repeat step 5
6. Optionally, Crick next button in findbar

Actual Results:
Find highlighted text is redrawn(flashing) each time when searching next / previous

Expected Results:
Find highlighted text should not be redrawn(flashing)

Comment 1

[Alice0775 White]

Regression window(set findbar.modalHighlight = false as release build)

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6e861a1843cb30d678bb4aa88c29cb9fbea61d1b&tochange=67e3ee9b41edc9d70863704fad44a50d283bb886

Regressed by:
67e3ee9b41edc9d70863704fad44a50d283bb886 Mike de Boer — Bug 1303874 - make the active window object part of the iterator params to make sure that similar iterator runs for different runs are not treated as the same, thus potentially yielding incorrect results. r=jaws

Comment 2

[Alice0775 White]

Screencast: https://youtu.be/S0J6GqTlMhM

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:mikedeboer, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Daniel Bodea [:danibodea]]

Setting the firefox74 flag based on the regressor.

Comment 5

[Ethan Tseng [:ethan]]

Mike, could you set the priority flag?

Comment 6

[Alice0775 White]

Screencast: https://youtu.be/sC42JmY5DW4