1605576 - Permafailing devtools/client/webconsole/test/browser/browser_webconsole_stubs_page_error.js | "ReferenceError: asdf is not defined" when Gecko 73 merges to Beta on 2020-01-06

Status: VERIFIED FIXED

(DevTools :: Console, defect, P2)

Description

[Natalia Csoregi [:nataliaCs]]

[Tracking Requested - why for this release]:
Central as Beta:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=a9116bffd43a99e4178fc73cc42135f703f07ac3&searchStr=devtools&selectedJob=282260140

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282260140&repo=try&lineNumber=5475

[task 2019-12-21T13:44:26.372Z] 13:44:26 INFO - @http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html:1:7
[task 2019-12-21T13:44:26.372Z] 13:44:26 INFO - @resource://testing-common/content-task.js line 110 > eval:6:29
[task 2019-12-21T13:44:26.372Z] 13:44:26 INFO - @resource://testing-common/content-task.js:111:29
[task 2019-12-21T13:44:26.372Z] 13:44:26 INFO -
[task 2019-12-21T13:44:26.372Z] 13:44:26 INFO - Console message: [JavaScript Error: "uncaught exception: "]
[task 2019-12-21T13:44:26.372Z] 13:44:26 INFO - @http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html:1:1
[task 2019-12-21T13:44:26.372Z] 13:44:26 INFO - @resource://testing-common/content-task.js line 110 > eval:6:29
[task 2019-12-21T13:44:26.372Z] 13:44:26 INFO - @resource://testing-common/content-task.js:111:29
[task 2019-12-21T13:44:26.373Z] 13:44:26 INFO -
[task 2019-12-21T13:44:26.373Z] 13:44:26 INFO - Buffered messages finished
[task 2019-12-21T13:44:26.373Z] 13:44:26 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_stubs_page_error.js | "ReferenceError: asdf is not defined" packet has expected value - Got {
[task 2019-12-21T13:44:26.373Z] 13:44:26 INFO - "pageError": {
[task 2019-12-21T13:44:26.373Z] 13:44:26 INFO - "errorMessage": "ReferenceError: asdf is not defined",
[task 2019-12-21T13:44:26.373Z] 13:44:26 INFO - "errorMessageName": "JSMSG_NOT_DEFINED",
[task 2019-12-21T13:44:26.373Z] 13:44:26 INFO - "exceptionDocURL": "https://developer.mozilla.org/docs/Web/JavaScript/Reference/Errors/Not_defined?utm_source=mozilla&utm_medium=firefox-console-errors&utm_campaign=default",
[task 2019-12-21T13:44:26.373Z] 13:44:26 INFO - "sourceName": "http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html",
[task 2019-12-21T13:44:26.374Z] 13:44:26 INFO - "sourceId": "server0.conn0.child1/source22",
[task 2019-12-21T13:44:26.374Z] 13:44:26 INFO - "lineText": "",
[task 2019-12-21T13:44:26.374Z] 13:44:26 INFO - "lineNumber": 3,
[task 2019-12-21T13:44:26.374Z] 13:44:26 INFO - "columnNumber": 5,
[task 2019-12-21T13:44:26.374Z] 13:44:26 INFO - "category": "content javascript",
[task 2019-12-21T13:44:26.374Z] 13:44:26 INFO - "innerWindowID": 8589934593,
[task 2019-12-21T13:44:26.374Z] 13:44:26 INFO - "timeStamp": 1573832650066,
[task 2019-12-21T13:44:26.374Z] 13:44:26 INFO - "warning": false,
[task 2019-12-21T13:44:26.374Z] 13:44:26 INFO - "error": false,
[task 2019-12-21T13:44:26.375Z] 13:44:26 INFO - "exception": true,

:nchevobbe could this be a regression from Bug 1530843 ?

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This fails because javascript.options.asyncstack is only set to true in Nightly and Developer Edition: https://searchfox.org/mozilla-central/rev/8d04c3f5332d470eeae5aa3dc0ed132359a339c1/modules/libpref/init/all.js#1121

The expectations get autogenerated by browser_webconsole_stubs_page_error.js and stub-generator-helpers.js

Panos, please check if a developer will be able to fix this before January 6th. Developer and reviewer of regressing bug 1530843 are on PTO. Thank you in advance.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

We'll take care of this when we're back next week.

Comment 3

[Intermittent Failures Robot]

31 failures in 95 pushes (0.326 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 31

Platform breakdown:

• linux64: 9
• macosx1014-64: 9
• windows10-64: 3
• linux64-shippable: 2
• macosx1014-64-shippable: 2
• windows10-64-shippable: 1
• windows7-32: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605576&startday=2019-12-25&endday=2019-12-25&tree=all

Comment 4

[Intermittent Failures Robot]

33 failures in 1365 pushes (0.024 failures/push) were associated with this bug in the last 7 days.

This is the #24 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• try: 33

Platform breakdown:

• linux64: 9
• macosx1014-64: 10
• windows10-64: 3
• linux64-shippable: 2
• macosx1014-64-shippable: 2
• windows10-64-shippable: 1
• windows7-32: 5
• windows7-32-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605576&startday=2019-12-23&endday=2019-12-29&tree=all

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Honza, could you please find an owner for this?

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1605576 - Set javascript.options.asyncstack in browser_webconsole_stubs_page_error.js and browser_webconsole_worker_error.js

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd42b4b1ae1a79fe04ca091684a440c2ba6a34f6

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

devtools/client/webconsole/test/browser/browser_webconsole_worker_error.js supposedly also needs the pref set: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd42b4b1ae1a79fe04ca091684a440c2ba6a34f6&selectedJob=283354045

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c053a4615ff7
Set javascript.options.asyncstack in browser_webconsole_stubs_page_error.js and browser_webconsole_worker_error.js r=nchevobbe

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7452a7fda3d8

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c053a4615ff7

Comment 13

[Andreea Pavel [:apavel]]

Verified fixed in latest beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=828df1c4377b2a99d7c256c9b33ce02f67f6c5cb