1605613 - Quick Filter search "No Results" text is chopped off on bottom by 1 pixel

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[webmaster2]

Attachment: no_results_1.jpg

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Search a folder using the filter; search for a anything that will not be found in order to produce the "No Results" message.

Actual results:

The message "No Results" has bottom 1 pixel row chopped off.

Comment 1

[webmaster2]

Attachment: Enlargement

Comment 2

[webmaster2]

Tested using Tbird version 68.3.1 on Mac.

Comment 3

[WaltS48 [:walts48]]

I'm seeing the same in Thunderbird 68.3.1 on Ubuntu 18.04.3 LTS and Windows 10.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1605613-search-not-found-increase.patch

The text baseline was directly on the bottom of the image. Made the image a bit taller to show the text elements below the baseline (g, j, y) too. The image was scaled when showing. I made it now unscaled to not get this huge font when a minimal font height is set.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9117478 [details] [diff] [review]
1605613-search-not-found-increase.patch

Review of attachment 9117478 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e108db02cb6d
Increase the search-not-found.svg height to give the text some space below the baseline. r=mkmelin

Comment 8

[Geoff Lankow (:darktrojan)]

72.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/99bdef847789eded6d8f1c5e17f998b857aff0e6

Comment 9

[Geoff Lankow (:darktrojan)]

68.4:
https://hg.mozilla.org/releases/comm-esr68/rev/4bdabef04631d5cfcb7c8e59e5019d7052c43573