Closed Bug 1605642 Opened 4 years ago Closed 4 years ago

Jiggly text on Zoom Animation

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mayankleoboy1, Assigned: aosmond)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

Attachments

(1 file)

Go to http://delhidentalcouncil.in/Registration/Contact.aspx
Scroll to the bottom where there are 3 boxes.
Hover mouse on any of the boxes
The text jiggles, and appears to shift horizontally

Could be a dupe of multiple WR snapping issue bugs

Blocks: wr-snap
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All

The glyphs no longer wiggle after bug 1604241 landed, but they still shimmer as the animation progresses.

Turns out, this is not snapping. This is a texture sampling problem, when the edge of the glyph also at the end of the texture. Adding padding around the texture solves the shimmering. Patch in progress.

Assignee: nobody → aosmond
Status: NEW → ASSIGNED

When we animate text, we rasterize the glyphs in an arbitrary local
space once, and scale them during the animation. Some glyphs may be
pressed against the edge of the texture, resulting in artifacts due to
how the sampling works in the shader. This patch fixes the sampling
issues by padding glyph textures with an extra transparent pixel border.
This only applies to glyphs that are rasterized in local space.

This patch does not add the extra padding for Mac because it is already
padding its glyphs for Mac-specific reasons, and does not appear to be
as suspectible to the problem.

Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ccc51104ad42
Fix glyph distortion during animations. r=lsalzman
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78

It still happens a little bit, but far less noticeable than before. This is within the range we should expect.

Regressions: 1604765
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: