Closed
Bug 1605769
Opened 6 years ago
Closed 6 years ago
Set current media playback state to the event source
Categories
(Core :: Audio/Video: Playback, task, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(4 files, 1 obsolete file)
|
Bug 1605769 - part1 : use `PlaybackState` in media controller and add a method to monitor its change
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
MediaControlService should know which controller is active and what playing state it is, then set the correct playback state to the event source.
| Assignee | ||
Comment 1•6 years ago
|
||
| Assignee | ||
Comment 2•6 years ago
|
||
| Assignee | ||
Comment 3•6 years ago
|
||
| Assignee | ||
Comment 4•6 years ago
|
||
| Assignee | ||
Comment 5•6 years ago
|
||
Since we would like to use PlaybackState in MediaController, we move it out from MediaEventSource and put it in MediaControl.h, which makes more sense because it actually represents media controller's playback state.
In addition, modify ePlayed to ePlaying and add one new state eStopped.
Updated•6 years ago
|
Attachment #9117621 -
Attachment description: Bug 1605769 - part1 : add new method to observe media controller's play state change. → Bug 1605769 - part1 : use `PlaybackState` in media controller and add a method to monitor its change
Updated•6 years ago
|
Attachment #9117805 -
Attachment is obsolete: true
Pushed by marc.streckfuss@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6868755789c3
part0 : extend PlaybackState and move it out from MediaEventSource. r=MeFisto94
https://hg.mozilla.org/integration/autoland/rev/914bdf2c92e2
part1 : use `PlaybackState` in media controller and add a method to monitor its change r=MeFisto94
https://hg.mozilla.org/integration/autoland/rev/2aff5b65e527
part2 : create controller manager to select main controller. r=MeFisto94
https://hg.mozilla.org/integration/autoland/rev/9fd0860cf333
part3 : set playback state to the event source according to the play state of the main controller. r=MeFisto94
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6868755789c3
https://hg.mozilla.org/mozilla-central/rev/914bdf2c92e2
https://hg.mozilla.org/mozilla-central/rev/2aff5b65e527
https://hg.mozilla.org/mozilla-central/rev/9fd0860cf333
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in
before you can comment on or make changes to this bug.
Description
•