1605880 - Use consistent fission perfherder data naming for talos/raptor/awsy

Status: VERIFIED FIXED

(Testing :: Performance, enhancement, P1)

Description

[Robert Wood [:rwood]]

As Chris noted, we are using different fission labels for perfherder data ('extraOptions') for talos/raptor/awsy:

• Talos tests are labeled fission:

https://treeherder.mozilla.org/perf.html#/graphs?highlightAlerts=1&series=mozilla-central,2199277,1,1&series=mozilla-central,1932043,1,1&series=mozilla-central,2199304,1,1&series=mozilla-central,1934592,1,1&timerange=604800

• Raptor tests are labeled fission_enabled (with an underscore):

https://treeherder.mozilla.org/perf.html#/graphs?highlightAlerts=1&series=mozilla-central,2195153,1,10&series=mozilla-central,1931773,1,10&series=mozilla-central,2195163,1,10&series=mozilla-central,2195170,1,10&series=mozilla-central,2195204,1,10&series=mozilla-central,2195237,1,10&timerange=1209600

• AWSY tests labeled fission-enabled (with a hyphen):

https://treeherder.mozilla.org/perf.html#/graphs?highlightAlerts=1&series=mozilla-central,1959473,1,4&series=mozilla-central,2168897,1,4&series=mozilla-central,2168907,1,4&series=mozilla-central,1959483,1,4&timerange=604800

Let's use the same fission label for all the frameworks for perfherder.

Comment 1

[Robert Wood [:rwood]]

I would suggest we just use "fission", if everyone agrees? That will make the perfherder graph labels shorter too.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

I'm sold on "fission"; thanks!

Comment 3

[Marian Raiciof [:marauder]]

I agree with the "fission" label. Thanks!

Comment 4

[Robert Wood [:rwood]]

Attachment: Bug 1605880 - Enable raptor-browsertime with visual metrics on Fenix (webrender off) and GVE for central and try only

Comment 5

[Robert Wood [:rwood]]

Oops attached patch to wrong bug; please disregard

Comment 6

[Robert Wood [:rwood]]

Attachment: Bug 1605880 - Use consistent fission perfherder data naming for talos/raptor/awsy

Comment 7

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=0c787791e3aa77983c165be57864a380bed568b6

Comment 8

[Robert Wood [:rwood]]

Updated patch with a fix for a non-related / pre-existing intermittent raptor unit test failure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59f83f66c65a27e3e822dba6b20ccdea09994208

Comment 9

[Robert Wood [:rwood]]

And just with the update for the lint fix:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=85b64c7cefdc7d8dda89a5ddd7795a9cca113c89

Comment 10

[Robert Wood [:rwood]]

(In reply to Robert Wood [:rwood] from comment #7)

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=0c787791e3aa77983c165be57864a380bed568b6

Looks good!

Raptor:

INFO - perftest-output Info: PERFHERDER_DATA: {"framework": {"name": "raptor"}, "application": {"version": "73.0a1", "name": "firefox"}, "suites": [{"value": 78.82673856314936, "extraOptions": ["fission"],

Talos:

INFO - PERFHERDER_DATA: {"framework": {"name": "talos"}, "suites": [{"extraOptions": ["e10s", "stylo", "fission"],

AWSY:

INFO - PERFHERDER_DATA: {"framework": {"name": "awsy"}, "suites": [{"extraOptions": ["tp6", "fission", "stylo"],

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a1d7fd259a6
Use consistent fission perfherder data naming for talos/raptor/awsy r=sparky,Marian

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0a1d7fd259a6

Comment 13

[Chris Peterson [:cpeterson]]

(In reply to Robert Wood [:rwood] from comment #1)

I would suggest we just use "fission", if everyone agrees? That will make the perfherder graph labels shorter too.

"fission" SGTM. Thanks!

(In reply to Pulsebot from comment #11)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a1d7fd259a6
Use consistent fission perfherder data naming for talos/raptor/awsy

Rob, is this GeckoView change to testing/raptor/test/test_cpu.py needed to fix the Fission test names? I don't know this code, but the change seems unrelated.

 def test_no_device():
-    raptor = RaptorAndroid('geckoview', 'org.mozilla.org.mozilla.geckoview_example', cpu_test=True)
+    raptor = RaptorAndroid('geckoview', 'org.mozilla.org.mozilla.geckoview_example',
+                           cpu_test=True, no_conditioned_profile=False)

Comment 14

[Robert Wood [:rwood]]

(In reply to Chris Peterson [:cpeterson] (PTO: December 24 – January 1) from comment #13)

Rob, is this GeckoView change to testing/raptor/test/test_cpu.py needed to fix the Fission test names? I don't know this code, but the change seems unrelated.

Yes it was unrelated but it fixed an intermittent raptor unit test failure that appeared in my try push; see Comment 8.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Robert Wood [:rwood] from comment #8)

Updated patch with a fix for a non-related / pre-existing intermittent raptor unit test failure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59f83f66c65a27e3e822dba6b20ccdea09994208

👍

Comment 16

[Chris Peterson [:cpeterson]]

Thanks! I see the new "fission" test names in Perfherder now.