Closed Bug 1605880 Opened 2 years ago Closed 2 years ago

Use consistent fission perfherder data naming for talos/raptor/awsy

Categories

(Testing :: Performance, enhancement, P1)

Version 3
enhancement

Tracking

(firefox73 verified)

VERIFIED FIXED
mozilla73
Tracking Status
firefox73 --- verified

People

(Reporter: rwood, Assigned: rwood)

Details

Attachments

(1 file, 1 obsolete file)

I would suggest we just use "fission", if everyone agrees? That will make the perfherder graph labels shorter too.

Flags: needinfo?(stephen.donner)
Flags: needinfo?(marian.raiciof)
Flags: needinfo?(cpeterson)

I'm sold on "fission"; thanks!

Flags: needinfo?(stephen.donner)

I agree with the "fission" label. Thanks!

Flags: needinfo?(marian.raiciof)

Oops attached patch to wrong bug; please disregard

Attachment #9117881 - Attachment is obsolete: true

Updated patch with a fix for a non-related / pre-existing intermittent raptor unit test failure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59f83f66c65a27e3e822dba6b20ccdea09994208

(In reply to Robert Wood [:rwood] from comment #7)

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=0c787791e3aa77983c165be57864a380bed568b6

Looks good!

Raptor:

INFO - perftest-output Info: PERFHERDER_DATA: {"framework": {"name": "raptor"}, "application": {"version": "73.0a1", "name": "firefox"}, "suites": [{"value": 78.82673856314936, "extraOptions": ["fission"],

Talos:

INFO - PERFHERDER_DATA: {"framework": {"name": "talos"}, "suites": [{"extraOptions": ["e10s", "stylo", "fission"],

AWSY:

INFO - PERFHERDER_DATA: {"framework": {"name": "awsy"}, "suites": [{"extraOptions": ["tp6", "fission", "stylo"],

Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a1d7fd259a6
Use consistent fission perfherder data naming for talos/raptor/awsy r=sparky,Marian
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73

(In reply to Robert Wood [:rwood] from comment #1)

I would suggest we just use "fission", if everyone agrees? That will make the perfherder graph labels shorter too.

"fission" SGTM. Thanks!

(In reply to Pulsebot from comment #11)

Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a1d7fd259a6
Use consistent fission perfherder data naming for talos/raptor/awsy

Rob, is this GeckoView change to testing/raptor/test/test_cpu.py needed to fix the Fission test names? I don't know this code, but the change seems unrelated.

 def test_no_device():
-    raptor = RaptorAndroid('geckoview', 'org.mozilla.org.mozilla.geckoview_example', cpu_test=True)
+    raptor = RaptorAndroid('geckoview', 'org.mozilla.org.mozilla.geckoview_example',
+                           cpu_test=True, no_conditioned_profile=False)
Flags: needinfo?(cpeterson) → needinfo?(rwood)

(In reply to Chris Peterson [:cpeterson] (PTO: December 24 – January 1) from comment #13)

Rob, is this GeckoView change to testing/raptor/test/test_cpu.py needed to fix the Fission test names? I don't know this code, but the change seems unrelated.

Yes it was unrelated but it fixed an intermittent raptor unit test failure that appeared in my try push; see Comment 8.

Flags: needinfo?(rwood)

(In reply to Robert Wood [:rwood] from comment #8)

Updated patch with a fix for a non-related / pre-existing intermittent raptor unit test failure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59f83f66c65a27e3e822dba6b20ccdea09994208

👍

Thanks! I see the new "fission" test names in Perfherder now.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.