about:downloads no longer shows scrollbars
Categories
(Firefox :: Downloads Panel, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox71 | --- | unaffected |
firefox72 | + | verified |
firefox73 | --- | verified |
People
(Reporter: Gijs, Assigned: Gijs)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
[Tracking Requested - why for this release]:
As yet unshipped UI regression
STR (checked on Windows, but likely cross-platform):
- download 3 or more files
- open about:downloads, resize until only 1.5-2 downloads are visible
ER:
there are scrollbars and the mouse scrollwheel can scroll the list
AR:
nope.
Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5e6b050c9427da9ae37ca4c7c8000ba5b47ceea8&tochange=1a85c571a4645798ba4d9295ba2504acac149ac8
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
Seems like we can just remove this stack?
Comment 2•1 year ago
|
||
Comment 3•1 year ago
|
||
(In reply to :Gijs (he/him) from comment #1)
Seems like we can just remove this stack?
Sounds like a better solution and appropriate in this case, similarly to bug 1596947. Feel free to craft a patch :)
Assignee | ||
Comment 4•1 year ago
|
||
Updated•1 year ago
|
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5a6af09b9760 allow downloads view to scroll by not enclosing it in a stack that sizes to match the view size, r=ntim
Comment 6•1 year ago
|
||
Comment on attachment 9117735 [details]
Bug 1605939 - allow downloads view to scroll by not enclosing it in a stack that sizes to match the view size, r?ntim,mak
Beta/Release Uplift Approval Request
- User impact if declined: about:downloads can't be scrolled when the content is overflowing
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment 0
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small front-end change.
- String changes made/needed: none
Updated•1 year ago
|
Comment 7•1 year ago
|
||
bugherder |
Comment on attachment 9117735 [details]
Bug 1605939 - allow downloads view to scroll by not enclosing it in a stack that sizes to match the view size, r?ntim,mak
Fix for annoying new regression, let's uplift for today's beta 11 build.
Comment 9•1 year ago
|
||
bugherderuplift |
Comment 10•1 year ago
|
||
Verified as fixed using Firefox 72 beta 11 and the latest Nightly 73.0a1 (Build ID: 20191226214311) on Windows 10 x 64, Ubuntu 18.04 and Mac OS X 10.14.
Updated•1 year ago
|
Description
•