Closed
Bug 160595
Opened 22 years ago
Closed 14 years ago
enter_bug.cgi does not show description of products that start with _
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: pbaker, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
3.07 KB,
patch
|
myk
:
review-
|
Details | Diff | Splinter Review |
This is similar to bug#160557. The enter_bug.cgi screen does not display the description of products that start with _. This also affects describecomponents.cgi as it shares the same code and template as enter_bug.cgi. I am working on the patch for this bug and will attach it very soon.
Reporter | ||
Comment 1•22 years ago
|
||
This fixes the problem on my bugzilla installation.
Reporter | ||
Comment 2•22 years ago
|
||
This should be all good to go if someone wants to review it.
Comment 3•22 years ago
|
||
And, similar to bug 160557, I'm not convinced that this is a good idea.
Comment 4•21 years ago
|
||
> This should be all good to go if someone wants to review it.
If you want someone to review it you should request this now by setting a
review+ flag next to your attachment.
OS: Linux → All
Hardware: PC → All
Comment 5•19 years ago
|
||
I redefine .item() to accept keys starting with an underscore. Both products and classifications choosers are affected.
Updated•19 years ago
|
Assignee: pbaker → LpSolit
Attachment #93632 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #187236 -
Flags: review?(myk)
Comment 6•19 years ago
|
||
Comment on attachment 187236 [details] [diff] [review] patch, v1 >+$Template::Stash::HASH_OPS->{ item } = >+ sub { >+ return $_[0]->{$_[1]}; >+ }; >+ According to a TT mailing list post from the author of TT, this is the preferred solution to the problem right now. http://www.template-toolkit.org/pipermail/templates/2004-January/005556.html This solution is good for now, but ultimately we should hack TT, adding a configuration option to turn off TT's feature for hiding hash keys, since we don't use it, and it hurts us. >+ [% IF proddesc.item("$p") %] >+ <td valign="top"> [% proddesc.item("$p") FILTER none %]</td> These should be able to be just proddesc.item(p). Are there any other uses of these (or other) hashes that need a similar fix?
Attachment #187236 -
Flags: review?(myk) → review-
Comment 7•19 years ago
|
||
As long as TT doesn't have a param to force him to display _private keys, I don't see what I could do here...
Assignee: LpSolit → create-and-change
Status: ASSIGNED → NEW
QA Contact: mattyt-bugzilla → default-qa
Comment 8•14 years ago
|
||
I cannot reproduce this issue in Bugzilla 3.4 and newer.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•