1606061 - [Fission] Make nsDocShell::SetTouchEventsOverride Fission compatible

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Similar to bug 1605243 using docShell.setTouchEventsOverride turns out to be not Fission compatible because it iterates over the child list:

https://searchfox.org/mozilla-central/rev/c79fc6e32a5b561205a71fcfef9112d34b4037ae/docshell/base/nsDocShell.cpp#2382-2387

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly (M6)

Comment 2

[Chris Peterson [:cpeterson]]

M6c

Comment 3

[Neha Kochar [:neha]]

Nika said this can be added to BrowsingContext fields.

Comment 4

[Steven MacLeod [:smacleod]]

Attachment: Bug 1606061 - move TouchEventsOverride to BrowsingContext. r=farre!

This change removes docshell's mTouchEventsOverride and replaces it
with a new BrowsingContext field TouchEventsOverrideInternal.
All uses of the old field have been replaced and an override should
now work under fission when there are cross-origin descendent frames.

---

Bug 1606061 - move usage of TouchEventsOverride to BrowsingContext.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98f9ddb69629
move TouchEventsOverride to BrowsingContext. r=farre,devtools-backward-compat-reviewers

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/98f9ddb69629