Closed Bug 1606095 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 20924 - [LayoutInstability] Fix flaky tests

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20924 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20924
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

[LayoutInstability] Fix flaky tests

In this CL, some 'await waitForAnimationFrames(2)' are added to wait for
the initial render of the test page before introducing the observer.
This removes flakiness of these tests in WPT.fyi. Other cleanups are
done in the test files.

Bug: 1036013
Change-Id: Ic2631faf03ad00c8e32013c100c3b4ab867be2b0
Reviewed-on: https://chromium-review.googlesource.com/1982708
WPT-Export-Revision: 7a4f2480c927a6fab16963ef861d14d46add138a

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

PRECONDITION_FAILED: 3
TIMEOUT : 3

Chrome

OK : 3
PASS : 3

Safari

PRECONDITION_FAILED: 3
TIMEOUT : 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/layout-instability/buffer-layout-shift.html: PRECONDITION_FAILED (Chrome: OK, Safari: PRECONDITION_FAILED)
Layout shift before onload is not buffered into the performance timeline.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/layout-instability/buffered-flag.html: PRECONDITION_FAILED (Chrome: OK, Safari: PRECONDITION_FAILED)
PerformanceObserver with buffered flag sees previous layout-shift entry.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/layout-instability/toJSON.html: PRECONDITION_FAILED (Chrome: OK, Safari: PRECONDITION_FAILED)
Test toJSON() in LayoutShift.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

PRECONDITION_FAILED: 3
TIMEOUT : 3

Chrome

OK : 3
PASS : 3

Safari

PRECONDITION_FAILED: 3
TIMEOUT : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/layout-instability/buffer-layout-shift.html: PRECONDITION_FAILED (Chrome: OK, Safari: PRECONDITION_FAILED)
Layout shift before onload is not buffered into the performance timeline.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/layout-instability/buffered-flag.html: PRECONDITION_FAILED (Chrome: OK, Safari: PRECONDITION_FAILED)
PerformanceObserver with buffered flag sees previous layout-shift entry.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/layout-instability/toJSON.html: PRECONDITION_FAILED (Chrome: OK, Safari: PRECONDITION_FAILED)
Test toJSON() in LayoutShift.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

PRECONDITION_FAILED: 3
TIMEOUT : 3

Chrome

OK : 3
PASS : 3

Safari

PRECONDITION_FAILED: 3
TIMEOUT : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/layout-instability/buffer-layout-shift.html: PRECONDITION_FAILED (Chrome: OK, Safari: PRECONDITION_FAILED)
Layout shift before onload is not buffered into the performance timeline.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/layout-instability/buffered-flag.html: PRECONDITION_FAILED (Chrome: OK, Safari: PRECONDITION_FAILED)
PerformanceObserver with buffered flag sees previous layout-shift entry.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/layout-instability/toJSON.html: PRECONDITION_FAILED (Chrome: OK, Safari: PRECONDITION_FAILED)
Test toJSON() in LayoutShift.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5212a318f36d
[wpt PR 20924] - [LayoutInstability] Fix flaky tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/87a6304c72aa
[wpt PR 20924] - Update wpt metadata, a=testonly

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

PRECONDITION_FAILED: 3
TIMEOUT : 3

Chrome

OK : 3
PASS : 3

Safari

PRECONDITION_FAILED: 3
TIMEOUT : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/layout-instability/buffer-layout-shift.html: PRECONDITION_FAILED (Chrome: OK, Safari: PRECONDITION_FAILED)
Layout shift before onload is not buffered into the performance timeline.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/layout-instability/buffered-flag.html: PRECONDITION_FAILED (Chrome: OK, Safari: PRECONDITION_FAILED)
PerformanceObserver with buffered flag sees previous layout-shift entry.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/layout-instability/toJSON.html: PRECONDITION_FAILED (Chrome: OK, Safari: PRECONDITION_FAILED)
Test toJSON() in LayoutShift.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.