1606152 - When adding a search engine I can't check the option "make this the current search engine"

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Florencia Di Ciocco, NI to vbalducci]

Attachment: Captura de pantalla de 2019-12-27 17-45-40.png

Steps to reproduce:

Go to about:preferences#search
Click the Find more search engines link.
Choose an add-on from the provided list (e.g. https://addons.mozilla.org/en-US/firefox/addon/duckduckgo-html/?src=search), click "add to firefox" and check the option "make this the current search engine"

Expected result:
The checkbox is checked and the add-on is installed and set as the default search engine

Actual result:
I can't check the checkbox. To be more precise, I have to click around the checkbox randomly until I'm able to check it.

Comment 1

[Florencia Di Ciocco, NI to vbalducci]

Attachment: search engine.mp4

Comment 2

[Mark Banner (:standard8)]

This works fine for me on Mac, so I suspect it is a Linux-only regression. Would you be able to try and use mozregression to get a regression range?

Comment 3

[Florencia Di Ciocco, NI to vbalducci]

Hi Mark,

Here's the pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cefb0e6f314aa176684e1fce4b71d649ca674c2d&tochange=70b2e0edb9a100ab95af8d7713f99dbc8ebd1ca0.

Regards, Flor.

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Florencia Di Ciocco from comment #3)

Hi Mark,

Here's the pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cefb0e6f314aa176684e1fce4b71d649ca674c2d&tochange=70b2e0edb9a100ab95af8d7713f99dbc8ebd1ca0.

Regards, Flor.

Thank you - marking Bug 1583925 as the cause of the regression.

Comment 5

[Julien Cristau [:jcristau]]

Bug 1583925 landed in 72. Are you sure it's unaffected?

Comment 6

[Florencia Di Ciocco, NI to vbalducci]

Hi Julien,

I see what you mean. It depends. FF72 goes from 2019-10-21 to 2019-12-02 and this was landed on 2019-11-26. So it depends on what version of FF72 you are using. If you are using the first ones, it's not affected. If you are using some of the latest 72 version, it is affected. I checked with the first one of FF72 and so I decided it wasn't affected. How should we mark this?

Comment 7

[Julien Cristau [:jcristau]]

The current version is what we care about.

Comment 8

[Julien Cristau [:jcristau]]

Fixed for 72.0-build4 by backout:
https://hg.mozilla.org/releases/mozilla-release/rev/d2bd57dbd560

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Should we consider backing out for Fx73 too with only a couple weeks left in the Beta cycle?

Comment 10

[Florencia Di Ciocco, NI to vbalducci]

Hi Ryan,

I'm testing this on FF 74.0a1 (2020-01-14) (64-bit) on ubuntu 18 and the bug is no longer present.

Regards, Flor.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Hi Flor, can you please test Beta73 also? Also, can you please try to find what fixed it on Nightly using the --find-fix option of mozregression? Thanks!

Comment 12

[Florencia Di Ciocco, NI to vbalducci]

Hi Ryan, sorry for the delay, I was finishing some Nightly Validation tests. So on Beta 73.0b5 (64-bit) the issue is not present. And this was solved on the seventh of January, here's the pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c177a0dfaceaf18bc97e0d444669567a3e05d20f&tochange=7e410d72f9b01ced9c3ce520ae3bedb9a812ce2f.

Regards, Flor.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Sounds like this was fixed by bug 1605724, which sounds entirely plausible. Thanks!

Comment 14

[Florencia Di Ciocco, NI to vbalducci]

Yes, I also thought that it made sense :) You're welcome and thanks to you too.