Closed Bug 1606158 Opened 4 years ago Closed 4 years ago

Simplify network columns as functional & memoized components

Categories

(DevTools :: Netmonitor, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: Harald, Assigned: Harald)

References

(Blocks 1 open bug)

Details

Attachments

(3 obsolete files)

Very simple (shallow props, no lifecycle) network columns like status, url, domain, etc can be simplified into lightweight functional components and memoized using React.memo.

When profiling on my MBP, RequestListColumnStatus for example shows up with 0.8ms per update, which is a lot just to render a green 200 box.

Assignee: nobody → hkirschner
Status: NEW → ASSIGNED
Attachment #9117921 - Attachment is obsolete: true
Attachment #9117924 - Attachment is obsolete: true
Attachment #9117925 - Attachment is obsolete: true

Patch didn't show any perf difference, so this would be an architectural "clean-up" that should be engineering driven.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: